diff mbox series

dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow 'input' and 'output-enable' properties

Message ID 20240313083828.5048-1-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow 'input' and 'output-enable' properties | expand

Commit Message

Lad, Prabhakar March 13, 2024, 8:38 a.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

On the RZ/G3S SMARC platform, the 'input' property is utilized in gpio-hog
nodes, and the 'output-enable' property is used for ETH0/1 TXC pins. Update
the binding documentation to include these properties, addressing the
following dtbs_check warnings:

arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
	'input' does not match any of the regexes: 'pinctrl-[0-9]+'
	True is not of type 'object'
	[[144, 1]] is not of type 'object'
	['key-1-gpio-irq'] is not of type 'object'
	from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#

arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: eth0: 'anyOf' conditional failed, one must be fixed:
	'mux', 'tx_ctl', 'txc' do not match any of the regexes: 'pinctrl-[0-9]+'
	'output-enable' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml      | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski March 13, 2024, 5:02 p.m. UTC | #1 
On 13/03/2024 09:38, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> On the RZ/G3S SMARC platform, the 'input' property is utilized in gpio-hog
> nodes, and the 'output-enable' property is used for ETH0/1 TXC pins. Update
> the binding documentation to include these properties, addressing the
> following dtbs_check warnings:
> 
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
> 	'input' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	True is not of type 'object'
> 	[[144, 1]] is not of type 'object'
> 	['key-1-gpio-irq'] is not of type 'object'
> 	from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
> 
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: eth0: 'anyOf' conditional failed, one must be fixed:
> 	'mux', 'tx_ctl', 'txc' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	'output-enable' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
> 

In the future, please trim the error messages only to relevant parts, e.g.

arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
	'input' does not match any of the regexes: 'pinctrl-[0-9]+'

Because all other four lines are really not helping.

Anyway, no need to resend just for that:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Lad, Prabhakar March 13, 2024, 10:08 p.m. UTC | #2 
Hi Krzysztof,

Thank you for the review.

On Wed, Mar 13, 2024 at 5:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/03/2024 09:38, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > On the RZ/G3S SMARC platform, the 'input' property is utilized in gpio-hog
> > nodes, and the 'output-enable' property is used for ETH0/1 TXC pins. Update
> > the binding documentation to include these properties, addressing the
> > following dtbs_check warnings:
> >
> > arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
> >       'input' does not match any of the regexes: 'pinctrl-[0-9]+'
> >       True is not of type 'object'
> >       [[144, 1]] is not of type 'object'
> >       ['key-1-gpio-irq'] is not of type 'object'
> >       from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
> >
> > arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: eth0: 'anyOf' conditional failed, one must be fixed:
> >       'mux', 'tx_ctl', 'txc' do not match any of the regexes: 'pinctrl-[0-9]+'
> >       'output-enable' does not match any of the regexes: 'pinctrl-[0-9]+'
> >       from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
> >
>
> In the future, please trim the error messages only to relevant parts, e.g.
>
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
>         'input' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Because all other four lines are really not helping.
>
Sure I will keep that in mind.

> Anyway, no need to resend just for that:
>
Thanks.

Cheers,
Prabhakar
Geert Uytterhoeven March 14, 2024, 8:51 a.m. UTC | #3 
On Wed, Mar 13, 2024 at 9:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> On the RZ/G3S SMARC platform, the 'input' property is utilized in gpio-hog
> nodes, and the 'output-enable' property is used for ETH0/1 TXC pins. Update
> the binding documentation to include these properties, addressing the
> following dtbs_check warnings:
>
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
>         'input' does not match any of the regexes: 'pinctrl-[0-9]+'
>         True is not of type 'object'
>         [[144, 1]] is not of type 'object'
>         ['key-1-gpio-irq'] is not of type 'object'
>         from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
>
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: eth0: 'anyOf' conditional failed, one must be fixed:
>         'mux', 'tx_ctl', 'txc' do not match any of the regexes: 'pinctrl-[0-9]+'
>         'output-enable' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rzg2l-pinctrl.yaml#
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.10, with the warning messages
trimmed.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
index d476de82e5c3..4d5a957fa232 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
@@ -120,7 +120,9 @@  additionalProperties:
         slew-rate: true
         gpio-hog: true
         gpios: true
+        input: true
         input-enable: true
+        output-enable: true
         output-high: true
         output-low: true
         line-name: true