| Message ID | 20240223162850.3914349-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [next] pinctrl: ocelot: remove redundant assignment to variable ret | expand |
On Fri, Feb 23, 2024 at 5:28 PM Colin Ian King <colin.i.king@gmail.com> wrote: > The variable ret is being assigned a value that is never read, it > is being re-assigned a value in every case statement in the following > switch statement. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/pinctrl/pinctrl-ocelot.c:1404:3: warning: Value stored to 'ret' > is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 52aadd6d72a8..be9b8c010167 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1401,7 +1401,6 @@ static int ocelot_hw_set_value(struct ocelot_pinctrl *info, if (info->pincfg) { const struct ocelot_pincfg_data *opd = info->pincfg_data; - ret = 0; switch (reg) { case PINCONF_BIAS: ret = ocelot_pincfg_clrsetbits(info, pin,
The variable ret is being assigned a value that is never read, it is being re-assigned a value in every case statement in the following switch statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/pinctrl/pinctrl-ocelot.c:1404:3: warning: Value stored to 'ret' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/pinctrl/pinctrl-ocelot.c | 1 - 1 file changed, 1 deletion(-)