| Message ID | 20231122105401.11006-1-raag.jadav@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] pinctrl: intel: use the correct _PM_OPS() export macro | expand |
On Wed, Nov 22, 2023 at 04:24:01PM +0530, Raag Jadav wrote: > Since we don't have runtime PM handles here, we should be using > EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can > discard it in case CONFIG_PM_SLEEP=n. Obviously correct fix, I've pushed to my review and testing queue, thanks!
On Wed, Nov 22, 2023 at 04:24:01PM +0530, Raag Jadav wrote: > Since we don't have runtime PM handles here, we should be using > EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can > discard it in case CONFIG_PM_SLEEP=n. > > Fixes: b10a74b5c0c1 ("pinctrl: intel: Provide Intel pin control wide PM ops structure") > Signed-off-by: Raag Jadav <raag.jadav@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 2367c2747a83..d6f29e6faab7 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1879,7 +1879,7 @@ static int intel_pinctrl_resume_noirq(struct device *dev) return 0; } -EXPORT_NS_GPL_DEV_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = { +EXPORT_NS_GPL_DEV_SLEEP_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = { NOIRQ_SYSTEM_SLEEP_PM_OPS(intel_pinctrl_suspend_noirq, intel_pinctrl_resume_noirq) };
Since we don't have runtime PM handles here, we should be using EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can discard it in case CONFIG_PM_SLEEP=n. Fixes: b10a74b5c0c1 ("pinctrl: intel: Provide Intel pin control wide PM ops structure") Signed-off-by: Raag Jadav <raag.jadav@intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: c5860e4a2737a8b29dc426c800d01c5be6aad811