| Message ID | 20231018145750.429385-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent | expand |
On Wed, 18 Oct 2023 at 16:57, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Add missing wakeup-parent property, already used by DTS to indicate that > pins are wakeup capable: > > sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > index e119a226a4b1..2173c5255638 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > @@ -28,6 +28,7 @@ properties: > gpio-controller: true > "#gpio-cells": true > gpio-ranges: true > + wakeup-parent: true > > gpio-reserved-ranges: > minItems: 1 > -- > 2.34.1 > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On 10/18/23 16:57, Krzysztof Kozlowski wrote: > Add missing wakeup-parent property, already used by DTS to indicate that > pins are wakeup capable: > > sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > index e119a226a4b1..2173c5255638 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > @@ -28,6 +28,7 @@ properties: > gpio-controller: true > "#gpio-cells": true > gpio-ranges: true > + wakeup-parent: true > > gpio-reserved-ranges: > minItems: 1 All the properties visiable in this diff sound reasonable to put in the common yaml, no? Konrad
On 18/10/2023 19:44, Konrad Dybcio wrote: > > > On 10/18/23 16:57, Krzysztof Kozlowski wrote: >> Add missing wakeup-parent property, already used by DTS to indicate that >> pins are wakeup capable: >> >> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >> index e119a226a4b1..2173c5255638 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >> @@ -28,6 +28,7 @@ properties: >> gpio-controller: true >> "#gpio-cells": true >> gpio-ranges: true >> + wakeup-parent: true >> >> gpio-reserved-ranges: >> minItems: 1 > All the properties visiable in this diff sound reasonable to > put in the common yaml, no? Is something missing from common? Best regards, Krzysztof
On 10/18/23 21:23, Krzysztof Kozlowski wrote: > On 18/10/2023 19:44, Konrad Dybcio wrote: >> >> >> On 10/18/23 16:57, Krzysztof Kozlowski wrote: >>> Add missing wakeup-parent property, already used by DTS to indicate that >>> pins are wakeup capable: >>> >>> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> index e119a226a4b1..2173c5255638 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml >>> @@ -28,6 +28,7 @@ properties: >>> gpio-controller: true >>> "#gpio-cells": true >>> gpio-ranges: true >>> + wakeup-parent: true >>> >>> gpio-reserved-ranges: >>> minItems: 1 >> All the properties visiable in this diff sound reasonable to >> put in the common yaml, no? > > Is something missing from common? No, I just forgot how the yaml worked and didn't notice we're essentially status=okaying the properties here.. Konrad
On Wed, 18 Oct 2023 16:57:50 +0200, Krzysztof Kozlowski wrote: > Add missing wakeup-parent property, already used by DTS to indicate that > pins are wakeup capable: > > sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Wed, Oct 18, 2023 at 4:57 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Add missing wakeup-parent property, already used by DTS to indicate that > pins are wakeup capable: > > sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Patch applied. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml index e119a226a4b1..2173c5255638 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml @@ -28,6 +28,7 @@ properties: gpio-controller: true "#gpio-cells": true gpio-ranges: true + wakeup-parent: true gpio-reserved-ranges: minItems: 1
Add missing wakeup-parent property, already used by DTS to indicate that pins are wakeup capable: sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 + 1 file changed, 1 insertion(+)