| Message ID | 20231003081519.27524-1-raag.jadav@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] pinctrl: baytrail: drop runtime PM support | expand |
On Tue, Oct 03, 2023 at 01:45:18PM +0530, Raag Jadav wrote: > Since Baytrail pinctrl device is not attached to acpi_lpss_pm_domain, > runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr() > as now we only have suspend and resume handles in place. > > No functional impact. > TODO: > Consider moving to DEFINE_LATE_DEV_PM_OPS() in the future once we have > enough users to account for its introduction. This is not related to the commit message. I'll drop it.
On Tue, Oct 03, 2023 at 11:59:33AM +0300, Andy Shevchenko wrote: > On Tue, Oct 03, 2023 at 01:45:18PM +0530, Raag Jadav wrote: > > Since Baytrail pinctrl device is not attached to acpi_lpss_pm_domain, > > runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr() > > as now we only have suspend and resume handles in place. > > > > No functional impact. > > > TODO: > > Consider moving to DEFINE_LATE_DEV_PM_OPS() in the future once we have > > enough users to account for its introduction. > > This is not related to the commit message. > I'll drop it. Ah, and next time, please do a cover letter for the series, it can be better managed from maintainer perspective.
On Tue, Oct 03, 2023 at 01:45:18PM +0530, Raag Jadav wrote: > Since Baytrail pinctrl device is not attached to acpi_lpss_pm_domain, > runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr() > as now we only have suspend and resume handles in place. > > No functional impact. > > TODO: > Consider moving to DEFINE_LATE_DEV_PM_OPS() in the future once we have > enough users to account for its introduction. > > Signed-off-by: Raag Jadav <raag.jadav@intel.com> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pinctrl/intel/pinctrl-baytrail.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c > index ec76e43527c5..14a61a262be1 100644 > --- a/drivers/pinctrl/intel/pinctrl-baytrail.c > +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c > @@ -16,7 +16,6 @@ > #include <linux/module.h> > #include <linux/types.h> > #include <linux/platform_device.h> > -#include <linux/pm_runtime.h> > #include <linux/property.h> > #include <linux/seq_file.h> > #include <linux/string_helpers.h> I just realized I forgot to add pm.h here. I'll send out a v2. Raag
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index ec76e43527c5..14a61a262be1 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -16,7 +16,6 @@ #include <linux/module.h> #include <linux/types.h> #include <linux/platform_device.h> -#include <linux/pm_runtime.h> #include <linux/property.h> #include <linux/seq_file.h> #include <linux/string_helpers.h> @@ -722,8 +721,6 @@ static int byt_gpio_request_enable(struct pinctrl_dev *pctl_dev, raw_spin_unlock_irqrestore(&byt_lock, flags); - pm_runtime_get(vg->dev); - return 0; } @@ -734,7 +731,6 @@ static void byt_gpio_disable_free(struct pinctrl_dev *pctl_dev, struct intel_pinctrl *vg = pinctrl_dev_get_drvdata(pctl_dev); byt_gpio_clear_triggering(vg, offset); - pm_runtime_put(vg->dev); } static void byt_gpio_direct_irq_check(struct intel_pinctrl *vg, @@ -1661,7 +1657,6 @@ static int byt_pinctrl_probe(struct platform_device *pdev) return ret; platform_set_drvdata(pdev, vg); - pm_runtime_enable(dev); return 0; } @@ -1750,26 +1745,15 @@ static int byt_gpio_resume(struct device *dev) return 0; } -static int byt_gpio_runtime_suspend(struct device *dev) -{ - return 0; -} - -static int byt_gpio_runtime_resume(struct device *dev) -{ - return 0; -} - static const struct dev_pm_ops byt_gpio_pm_ops = { LATE_SYSTEM_SLEEP_PM_OPS(byt_gpio_suspend, byt_gpio_resume) - RUNTIME_PM_OPS(byt_gpio_runtime_suspend, byt_gpio_runtime_resume, NULL) }; static struct platform_driver byt_gpio_driver = { .probe = byt_pinctrl_probe, .driver = { .name = "byt_gpio", - .pm = pm_ptr(&byt_gpio_pm_ops), + .pm = pm_sleep_ptr(&byt_gpio_pm_ops), .acpi_match_table = byt_gpio_acpi_match, .suppress_bind_attrs = true, },