| Message ID | 20230717141845.41415-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] gpio: bcm-kona: Make driver OF-independent | expand |
Hi Andy, kernel test robot noticed the following build errors: [auto build test ERROR on brgl/gpio/for-next] [also build test ERROR on linus/master v6.5-rc2 next-20230718] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpio-bcm-kona-remove-unneeded-platform_set_drvdata-call/20230718-174129 base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next patch link: https://lore.kernel.org/r/20230717141845.41415-1-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v2 1/3] gpio: bcm-kona: Make driver OF-independent config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230718/202307182321.w0jEsUc4-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230718/202307182321.w0jEsUc4-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307182321.w0jEsUc4-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/gpio/gpio-bcm-kona.c: In function 'bcm_kona_gpio_set_debounce': >> drivers/gpio/gpio-bcm-kona.c:266:17: error: implicit declaration of function 'dev_err' [-Werror=implicit-function-declaration] 266 | dev_err(chip->parent, "Debounce value %u not in range\n", | ^~~~~~~ drivers/gpio/gpio-bcm-kona.c: In function 'bcm_kona_gpio_probe': >> drivers/gpio/gpio-bcm-kona.c:559:35: error: invalid use of undefined type 'struct platform_device' 559 | struct device *dev = &pdev->dev; | ^~ >> drivers/gpio/gpio-bcm-kona.c:566:21: error: implicit declaration of function 'devm_kzalloc' [-Werror=implicit-function-declaration] 566 | kona_gpio = devm_kzalloc(dev, sizeof(*kona_gpio), GFP_KERNEL); | ^~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:566:19: warning: assignment to 'struct bcm_kona_gpio *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 566 | kona_gpio = devm_kzalloc(dev, sizeof(*kona_gpio), GFP_KERNEL); | ^ >> drivers/gpio/gpio-bcm-kona.c:572:15: error: implicit declaration of function 'platform_irq_count' [-Werror=implicit-function-declaration] 572 | ret = platform_irq_count(pdev); | ^~~~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:577:24: error: implicit declaration of function 'dev_err_probe' [-Werror=implicit-function-declaration] 577 | return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n"); | ^~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:586:28: error: implicit declaration of function 'devm_kcalloc' [-Werror=implicit-function-declaration] 586 | kona_gpio->banks = devm_kcalloc(dev, | ^~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:586:26: warning: assignment to 'struct bcm_kona_gpio_bank *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 586 | kona_gpio->banks = devm_kcalloc(dev, | ^ drivers/gpio/gpio-bcm-kona.c:594:9: error: implicit declaration of function 'platform_set_drvdata' [-Werror=implicit-function-declaration] 594 | platform_set_drvdata(pdev, kona_gpio); | ^~~~~~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:607:31: error: implicit declaration of function 'devm_platform_ioremap_resource' [-Werror=implicit-function-declaration] 607 | kona_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:607:29: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 607 | kona_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0); | ^ >> drivers/gpio/gpio-bcm-kona.c:616:29: error: implicit declaration of function 'platform_get_irq' [-Werror=implicit-function-declaration] 616 | bank->irq = platform_get_irq(pdev, i); | ^~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:625:9: error: implicit declaration of function 'dev_info' [-Werror=implicit-function-declaration] 625 | dev_info(&pdev->dev, "Setting up Kona GPIO\n"); | ^~~~~~~~ drivers/gpio/gpio-bcm-kona.c:625:23: error: invalid use of undefined type 'struct platform_device' 625 | dev_info(&pdev->dev, "Setting up Kona GPIO\n"); | ^~ drivers/gpio/gpio-bcm-kona.c: At top level: >> drivers/gpio/gpio-bcm-kona.c:651:15: error: variable 'bcm_kona_gpio_driver' has initializer but incomplete type 651 | static struct platform_driver bcm_kona_gpio_driver = { | ^~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:652:10: error: 'struct platform_driver' has no member named 'driver' 652 | .driver = { | ^~~~~~ >> drivers/gpio/gpio-bcm-kona.c:652:19: error: extra brace group at end of initializer 652 | .driver = { | ^ drivers/gpio/gpio-bcm-kona.c:652:19: note: (near initialization for 'bcm_kona_gpio_driver') >> drivers/gpio/gpio-bcm-kona.c:652:19: warning: excess elements in struct initializer drivers/gpio/gpio-bcm-kona.c:652:19: note: (near initialization for 'bcm_kona_gpio_driver') >> drivers/gpio/gpio-bcm-kona.c:656:10: error: 'struct platform_driver' has no member named 'probe' 656 | .probe = bcm_kona_gpio_probe, | ^~~~~ drivers/gpio/gpio-bcm-kona.c:656:18: warning: excess elements in struct initializer 656 | .probe = bcm_kona_gpio_probe, | ^~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-bcm-kona.c:656:18: note: (near initialization for 'bcm_kona_gpio_driver') >> drivers/gpio/gpio-bcm-kona.c:658:1: warning: data definition has no type or storage class 658 | builtin_platform_driver(bcm_kona_gpio_driver); | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpio/gpio-bcm-kona.c:658:1: error: type defaults to 'int' in declaration of 'builtin_platform_driver' [-Werror=implicit-int] >> drivers/gpio/gpio-bcm-kona.c:658:1: warning: parameter names (without types) in function declaration drivers/gpio/gpio-bcm-kona.c:651:31: error: storage size of 'bcm_kona_gpio_driver' isn't known 651 | static struct platform_driver bcm_kona_gpio_driver = { | ^~~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-bcm-kona.c:651:31: warning: 'bcm_kona_gpio_driver' defined but not used [-Wunused-variable] cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SM_GCC_8350 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]: - SM_VIDEOCC_8350 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] WARNING: unmet direct dependencies detected for SM_GCC_8450 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]: - SM_GPUCC_8450 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] - SM_VIDEOCC_8450 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] WARNING: unmet direct dependencies detected for SM_GCC_8550 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]: - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] vim +/dev_err +266 drivers/gpio/gpio-bcm-kona.c 757651e3d60e5b Markus Mayer 2013-09-10 253 757651e3d60e5b Markus Mayer 2013-09-10 254 static int bcm_kona_gpio_set_debounce(struct gpio_chip *chip, unsigned gpio, 757651e3d60e5b Markus Mayer 2013-09-10 255 unsigned debounce) 757651e3d60e5b Markus Mayer 2013-09-10 256 { 757651e3d60e5b Markus Mayer 2013-09-10 257 struct bcm_kona_gpio *kona_gpio; 757651e3d60e5b Markus Mayer 2013-09-10 258 void __iomem *reg_base; 757651e3d60e5b Markus Mayer 2013-09-10 259 u32 val, res; 757651e3d60e5b Markus Mayer 2013-09-10 260 unsigned long flags; 757651e3d60e5b Markus Mayer 2013-09-10 261 ba4a74485a32c1 Linus Walleij 2015-12-04 262 kona_gpio = gpiochip_get_data(chip); 757651e3d60e5b Markus Mayer 2013-09-10 263 reg_base = kona_gpio->reg_base; 757651e3d60e5b Markus Mayer 2013-09-10 264 /* debounce must be 1-128ms (or 0) */ 757651e3d60e5b Markus Mayer 2013-09-10 265 if ((debounce > 0 && debounce < 1000) || debounce > 128000) { 58383c78425e4e Linus Walleij 2015-11-04 @266 dev_err(chip->parent, "Debounce value %u not in range\n", 757651e3d60e5b Markus Mayer 2013-09-10 267 debounce); 757651e3d60e5b Markus Mayer 2013-09-10 268 return -EINVAL; 757651e3d60e5b Markus Mayer 2013-09-10 269 } 757651e3d60e5b Markus Mayer 2013-09-10 270 757651e3d60e5b Markus Mayer 2013-09-10 271 /* calculate debounce bit value */ 757651e3d60e5b Markus Mayer 2013-09-10 272 if (debounce != 0) { 757651e3d60e5b Markus Mayer 2013-09-10 273 /* Convert to ms */ 757651e3d60e5b Markus Mayer 2013-09-10 274 debounce /= 1000; 757651e3d60e5b Markus Mayer 2013-09-10 275 /* find the MSB */ 757651e3d60e5b Markus Mayer 2013-09-10 276 res = fls(debounce) - 1; 757651e3d60e5b Markus Mayer 2013-09-10 277 /* Check if MSB-1 is set (round up or down) */ 757651e3d60e5b Markus Mayer 2013-09-10 278 if (res > 0 && (debounce & BIT(res - 1))) 757651e3d60e5b Markus Mayer 2013-09-10 279 res++; 757651e3d60e5b Markus Mayer 2013-09-10 280 } 757651e3d60e5b Markus Mayer 2013-09-10 281 757651e3d60e5b Markus Mayer 2013-09-10 282 /* spin lock for read-modify-write of the GPIO register */ c69fcea57e9d2b Julia Cartwright 2017-03-09 283 raw_spin_lock_irqsave(&kona_gpio->lock, flags); 757651e3d60e5b Markus Mayer 2013-09-10 284 757651e3d60e5b Markus Mayer 2013-09-10 285 val = readl(reg_base + GPIO_CONTROL(gpio)); 757651e3d60e5b Markus Mayer 2013-09-10 286 val &= ~GPIO_GPCTR0_DBR_MASK; 757651e3d60e5b Markus Mayer 2013-09-10 287 757651e3d60e5b Markus Mayer 2013-09-10 288 if (debounce == 0) { 757651e3d60e5b Markus Mayer 2013-09-10 289 /* disable debounce */ 757651e3d60e5b Markus Mayer 2013-09-10 290 val &= ~GPIO_GPCTR0_DB_ENABLE_MASK; 757651e3d60e5b Markus Mayer 2013-09-10 291 } else { 757651e3d60e5b Markus Mayer 2013-09-10 292 val |= GPIO_GPCTR0_DB_ENABLE_MASK | 757651e3d60e5b Markus Mayer 2013-09-10 293 (res << GPIO_GPCTR0_DBR_SHIFT); 757651e3d60e5b Markus Mayer 2013-09-10 294 } 757651e3d60e5b Markus Mayer 2013-09-10 295 757651e3d60e5b Markus Mayer 2013-09-10 296 writel(val, reg_base + GPIO_CONTROL(gpio)); 757651e3d60e5b Markus Mayer 2013-09-10 297 c69fcea57e9d2b Julia Cartwright 2017-03-09 298 raw_spin_unlock_irqrestore(&kona_gpio->lock, flags); 757651e3d60e5b Markus Mayer 2013-09-10 299 757651e3d60e5b Markus Mayer 2013-09-10 300 return 0; 757651e3d60e5b Markus Mayer 2013-09-10 301 } 757651e3d60e5b Markus Mayer 2013-09-10 302
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 638f0e771105..a70622d32a3b 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -191,7 +191,7 @@ config GPIO_RASPBERRYPI_EXP config GPIO_BCM_KONA bool "Broadcom Kona GPIO" - depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST) + depends on ARCH_BCM_MOBILE || COMPILE_TEST help Turn on GPIO support for Broadcom "Kona" chips. diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 70770429ba48..0aa7d710509d 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -8,12 +8,13 @@ #include <linux/bitops.h> #include <linux/err.h> -#include <linux/io.h> #include <linux/gpio/driver.h> -#include <linux/of_device.h> #include <linux/init.h> +#include <linux/io.h> #include <linux/irqdomain.h> #include <linux/irqchip/chained_irq.h> +#include <linux/mod_devicetable.h> +#include <linux/property.h> #define BCM_GPIO_PASSWD 0x00a5a501 #define GPIO_PER_BANK 32 @@ -556,19 +557,12 @@ static void bcm_kona_gpio_reset(struct bcm_kona_gpio *kona_gpio) static int bcm_kona_gpio_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - const struct of_device_id *match; struct bcm_kona_gpio_bank *bank; struct bcm_kona_gpio *kona_gpio; struct gpio_chip *chip; int ret; int i; - match = of_match_device(bcm_kona_gpio_of_match, dev); - if (!match) { - dev_err(dev, "Failed to find gpio controller\n"); - return -ENODEV; - } - kona_gpio = devm_kzalloc(dev, sizeof(*kona_gpio), GFP_KERNEL); if (!kona_gpio) return -ENOMEM; @@ -601,10 +595,10 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) chip->parent = dev; chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK; - kona_gpio->irq_domain = irq_domain_add_linear(dev->of_node, - chip->ngpio, - &bcm_kona_irq_ops, - kona_gpio); + kona_gpio->irq_domain = irq_domain_create_linear(dev_fwnode(dev), + chip->ngpio, + &bcm_kona_irq_ops, + kona_gpio); if (!kona_gpio->irq_domain) { dev_err(dev, "Couldn't allocate IRQ domain\n"); return -ENXIO;
There is nothing in the driver that requires OF APIs, make the driver OF independent. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: new patch drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-bcm-kona.c | 20 +++++++------------- 2 files changed, 8 insertions(+), 14 deletions(-)