| Message ID | 20230712074553.35907-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: gpio: snps,dw-apb: allow gpio-line-names | expand |
On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote: > Allow the GPIO controller subnode to define GPIO names. Already used in > at least on DTS: s/on/one > > bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' Acked-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index b391cc1b4590..209f03bba0a7 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -61,6 +61,10 @@ patternProperties: > '#gpio-cells': > const: 2 > > + gpio-line-names: > + minItems: 1 > + maxItems: 32 > + > ngpios: > default: 32 > minimum: 1 > -- > 2.34.1 >
On Wed, Jul 12, 2023 at 12:53:00PM +0300, Serge Semin wrote: > On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote: > > Allow the GPIO controller subnode to define GPIO names. Are we going to do this for each GPIO controller bindings? Can it be done once for all please?
On Wed, Jul 12, 2023 at 06:28:40PM +0300, Andy Shevchenko wrote: > On Wed, Jul 12, 2023 at 12:53:00PM +0300, Serge Semin wrote: > > On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote: > > > Allow the GPIO controller subnode to define GPIO names. > > Are we going to do this for each GPIO controller bindings? Can it be done once > for all please? AFAIU the DT-binding schemas which have "unevaluatedProperties: false" property specified won't have such problem since any DT property with "*-names" is already evaluated by the dt-validate core. Meanwhile in this case the schema has "additionalProperties: false" property which prohibits any none-explicitly defined property in the node. Regarding the "gpio-line-names" DT-property constraints. Alas it can't be done generically because at least a number of items is device specific. -Serge(y) > > -- > With Best Regards, > Andy Shevchenko > >
On 12/07/2023 17:28, Andy Shevchenko wrote: > On Wed, Jul 12, 2023 at 12:53:00PM +0300, Serge Semin wrote: >> On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote: >>> Allow the GPIO controller subnode to define GPIO names. > > Are we going to do this for each GPIO controller bindings? Can it be done once > for all please? No, because sizes differ. Although here the size is anyway flexible, so not much benefit of it, but in other GPIO controllers it is not flexible. Best regards, Krzysztof
On Wed, 12 Jul 2023 09:45:53 +0200, Krzysztof Kozlowski wrote: > Allow the GPIO controller subnode to define GPIO names. Already used in > at least on DTS: > > bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Wed, Jul 12, 2023 at 9:45 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Allow the GPIO controller subnode to define GPIO names. Already used in > at least on DTS: > > bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index b391cc1b4590..209f03bba0a7 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -61,6 +61,10 @@ patternProperties: > '#gpio-cells': > const: 2 > > + gpio-line-names: > + minItems: 1 > + maxItems: 32 > + > ngpios: > default: 32 > minimum: 1 > -- > 2.34.1 > Applied, thanks! Bart
diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml index b391cc1b4590..209f03bba0a7 100644 --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml @@ -61,6 +61,10 @@ patternProperties: '#gpio-cells': const: 2 + gpio-line-names: + minItems: 1 + maxItems: 32 + ngpios: default: 32 minimum: 1
Allow the GPIO controller subnode to define GPIO names. Already used in at least on DTS: bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++ 1 file changed, 4 insertions(+)