diff mbox series

pinctrl: mlxbf3: remove broken Kconfig 'select'

Message ID 20230619082104.699331-1-arnd@kernel.org
State New
Headers show
Series pinctrl: mlxbf3: remove broken Kconfig 'select' | expand

Commit Message

Arnd Bergmann June 19, 2023, 8:20 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
the MELLANOX_PLATFORM symbol does not exist in the tree:

WARNING: unmet direct dependencies detected for GPIO_MLXBF3
  Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
  Selected by [y]:
  - PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])

As it turns out, the pinctlr driver still builds fine without this, so just
remove the select statement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij June 19, 2023, 8:51 a.m. UTC | #1 
On Mon, Jun 19, 2023 at 10:21 AM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The new pinctrl driver selects GPIO_MLXBF3, but that can not be enabled yet because
> the MELLANOX_PLATFORM symbol does not exist in the tree:
>
> WARNING: unmet direct dependencies detected for GPIO_MLXBF3
>   Depends on [n]: GPIOLIB [=y] && PCI [=n] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
>   Selected by [y]:
>   - PINCTRL_MLXBF3 [=y] && PINCTRL [=y] && (MELLANOX_PLATFORM [=n] && ARM64 [=y] || COMPILE_TEST [=y])
>
> As it turns out, the pinctlr driver still builds fine without this, so just
> remove the select statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 77ff9a641aebf..57d57af1f624e 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -510,7 +510,6 @@  config PINCTRL_MLXBF3
 	select PINMUX
 	select GPIOLIB
 	select GPIOLIB_IRQCHIP
-	select GPIO_MLXBF3
 	help
 	  Say Y to select the pinctrl driver for BlueField-3 SoCs.
 	  This pin controller allows selecting the mux function for