diff mbox series

[2/2] dt-bindings: gpio: vf610: update gpio-ranges

Message ID 20230328052912.1957000-2-peng.fan@oss.nxp.com
State New
Headers show
Series [1/2] dt-bindings: gpio: fsl-imx-gpio: update gpio-ranges | expand

Commit Message

Peng Fan (OSS) March 28, 2023, 5:29 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

1 is not enough for i.MX9, enlarge it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski March 28, 2023, 2:45 p.m. UTC | #1 
On 28/03/2023 07:29, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> 1 is not enough for i.MX9, enlarge it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Andrew Lunn March 28, 2023, 2:48 p.m. UTC | #2 
On Tue, Mar 28, 2023 at 01:29:12PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> 1 is not enough for i.MX9, enlarge it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 ++-

I'm not that knowledgeable about i.MX9, but i thought vf610 was
Vybrid, which is not an i.MX9. Does i.MX9 reuse the Vybrid GPIO
controller? Is this change also valid for the Vybrid?

	Andrew
Peng Fan March 29, 2023, 9:21 a.m. UTC | #3 
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: 2023年3月28日 22:48
> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> Cc: linus.walleij@linaro.org; brgl@bgdev.pl; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> dl-linux-imx <linux-imx@nxp.com>; stefan@agner.ch; linux-
> gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Peng Fan
> <peng.fan@nxp.com>
> Subject: Re: [PATCH 2/2] dt-bindings: gpio: vf610: update gpio-ranges
> 
> On Tue, Mar 28, 2023 at 01:29:12PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > 1 is not enough for i.MX9, enlarge it.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 ++-
> 
> I'm not that knowledgeable about i.MX9, but i thought vf610 was Vybrid,
> which is not an i.MX9. Does i.MX9 reuse the Vybrid GPIO controller? Is this
> change also valid for the Vybrid?
[Peng Fan] 

i.MX9 reuse the gpio-vf610 driver and yaml dtschema. There are some
minor differences from hardware level. The gpio-ranges will also impact
vybrid, but this may not matter.

Regards,
Peng.
> 
> 	Andrew
Andrew Lunn March 29, 2023, 12:14 p.m. UTC | #4 
> i.MX9 reuse the gpio-vf610 driver and yaml dtschema. There are some
> minor differences from hardware level. The gpio-ranges will also impact
> vybrid, but this may not matter.

So maybe use a constraint to limit it to 1 for everything other than
fsl,imx93-gpio?

	Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
index d2c39dba56ad..7ba834e2a238 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
@@ -59,7 +59,8 @@  properties:
       - const: port
 
   gpio-ranges:
-    maxItems: 1
+    minItems: 1
+    maxItems: 16
 
 required:
   - compatible