| Message ID | 20230120165103.1278852-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: pinctrl: qcom,pmic-mpp: Rename "mpp" child node names to "-pins$" | expand |
On 20/01/2023 17:51, Rob Herring wrote: > Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or > suffix. Change the node name pattern to "-pins$" to align with other > Qualcomm pinctrl bindings. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - Use "-pins$" for pattern instead > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 20 Jan 2023 10:51:03 -0600, Rob Herring wrote: > Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or > suffix. Change the node name pattern to "-pins$" to align with other > Qualcomm pinctrl bindings. > > Or instead of review let me grab it for Linus: Applied, thanks! [1/1] dt-bindings: pinctrl: qcom,pmic-mpp: Rename "mpp" child node names to "-pins$" https://git.kernel.org/krzk/linux-dt/c/5682f23bd3daf8d66f0a4c0fa0e5645b324e7014 Best regards,
On Fri, Jan 20, 2023 at 6:42 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On Fri, 20 Jan 2023 10:51:03 -0600, Rob Herring wrote: > > Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or > > suffix. Change the node name pattern to "-pins$" to align with other > > Qualcomm pinctrl bindings. > > > > > > Or instead of review let me grab it for Linus: > > Applied, thanks! Thanks Krzysztof! Linus
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml index 72cce38bc1ce..9412b9362328 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml @@ -74,7 +74,7 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-pmic-mpp-state" - patternProperties: - "mpp": + '-pins$': $ref: "#/$defs/qcom-pmic-mpp-state" additionalProperties: false @@ -179,7 +179,7 @@ examples: }; default-state { - gpio-mpp { + gpio-pins { pins = "mpp1", "mpp2", "mpp3", "mpp4"; function = "digital"; input-enable;
Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or suffix. Change the node name pattern to "-pins$" to align with other Qualcomm pinctrl bindings. Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Use "-pins$" for pattern instead --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)