| Message ID | 20221222161420.172824-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: add input-enable and bias-bus-hold | expand |
On Thu, 22 Dec 2022 17:14:20 +0100, Krzysztof Kozlowski wrote: > Allow bias-bus-hold and input-enable properties (already used in SM8450): > > sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'function' is a required property > 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > 'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+' > > Compact the properties which are just set to true for readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. Add input-enable. > --- > .../bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, Dec 22, 2022 at 5:14 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Allow bias-bus-hold and input-enable properties (already used in SM8450): > > sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'function' is a required property > 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > 'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+' > > Compact the properties which are just set to true for readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Looks good, is this something I should be applying directly or are you collecting some big qualcomm pull requests like last time? Yours, Linus Walleij
On 09/01/2023 14:31, Linus Walleij wrote: > On Thu, Dec 22, 2022 at 5:14 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> Allow bias-bus-hold and input-enable properties (already used in SM8450): >> >> sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed: >> 'pins' is a required property >> 'function' is a required property >> 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' >> 'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+' >> >> Compact the properties which are just set to true for readability. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Looks good, is this something I should be applying directly or are > you collecting some big qualcomm pull requests like last time? I have just nine patches so far and it looks it is the end of cleanups/work on Qualcomm pinctrl. Of course maybe something will pop-up later. It's up to you how would you prefer to take them. There are few patches from other people (also adding new devices/bindings), but I did not notice any conflicts with my sets. Best regards, Krzysztof
On Thu, Dec 22, 2022 at 5:14 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Allow bias-bus-hold and input-enable properties (already used in SM8450): > > sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'function' is a required property > 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > 'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+' > > Compact the properties which are just set to true for readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml index 01a0a4a40ba5..e04d094d1946 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml @@ -96,14 +96,12 @@ $defs: 2: Lower Slew rate (slower edges) 3: Reserved (No adjustments) + bias-bus-hold: true bias-pull-down: true - bias-pull-up: true - bias-disable: true - + input-enable: true output-high: true - output-low: true required:
Allow bias-bus-hold and input-enable properties (already used in SM8450): sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+' 'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+' Compact the properties which are just set to true for readability. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Add input-enable. --- .../bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)