| Message ID | 20221219192016.1396950-3-dmitry.torokhov@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] gpiolib: of: remove of_gpio_count() | expand |
On Mon, Dec 19, 2022 at 11:20:14AM -0800, Dmitry Torokhov wrote: > The function is only being called form the main gpiolib module, so > remove comment saying that it is also used by external callers. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/gpio/gpiolib-of.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 6724e375678d..6114c5b3d2ce 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -76,12 +76,6 @@ static int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id) > return of_gpio_named_count(np, "gpios"); > } > > -/* > - * This is used by external users of of_gpio_count() from <linux/of_gpio.h> > - * > - * FIXME: get rid of those external users by converting them to GPIO > - * descriptors and let them all use gpiod_count() > - */ > int of_gpio_get_count(struct device *dev, const char *con_id) > { > int ret; > -- > 2.39.0.314.g84b9a713c41-goog >
On Mon, Dec 19, 2022 at 8:20 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > The function is only being called form the main gpiolib module, so > remove comment saying that it is also used by external callers. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> BTW: good work on this, much appreciated! Yours, Linus Walleij
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 6724e375678d..6114c5b3d2ce 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -76,12 +76,6 @@ static int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id) return of_gpio_named_count(np, "gpios"); } -/* - * This is used by external users of of_gpio_count() from <linux/of_gpio.h> - * - * FIXME: get rid of those external users by converting them to GPIO - * descriptors and let them all use gpiod_count() - */ int of_gpio_get_count(struct device *dev, const char *con_id) { int ret;
The function is only being called form the main gpiolib module, so remove comment saying that it is also used by external callers. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/gpio/gpiolib-of.c | 6 ------ 1 file changed, 6 deletions(-)