diff mbox series

[libgpiod,11/11] bindings: python: extend setup.py

Message ID 20221130124231.1054001-12-brgl@bgdev.pl
State New
Headers show
Series treewide: an assortment of tweaks and improvements | expand

Commit Message

Bartosz Golaszewski Nov. 30, 2022, 12:42 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Add additional information to setup.py. This will be visible in the EGG
file.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 bindings/python/setup.py | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andy Shevchenko Nov. 30, 2022, 2:09 p.m. UTC | #1 
On Wed, Nov 30, 2022 at 01:42:31PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Add additional information to setup.py. This will be visible in the EGG
> file.

...

>      packages=find_packages(include=["gpiod"]),
>      ext_modules=extensions,
>      version=__version__,
> +    author="Bartosz Golaszewski",
> +    author_email="brgl@bgdev.pl",
> +    description="Python bindings for libgpiod",
> +    platforms=["linux"],

> +    license="LGPLv2.1",

Is it applicable to the bindings only? I am not familiar with the code base,
but one of the patches in this series makes me wonder if you are not going to
make same mistake by licensing tools, if any written in pure Python, with a
wrong license.
Bartosz Golaszewski Nov. 30, 2022, 4:16 p.m. UTC | #2 
On Wed, Nov 30, 2022 at 3:09 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Nov 30, 2022 at 01:42:31PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add additional information to setup.py. This will be visible in the EGG
> > file.
>
> ...
>
> >      packages=find_packages(include=["gpiod"]),
> >      ext_modules=extensions,
> >      version=__version__,
> > +    author="Bartosz Golaszewski",
> > +    author_email="brgl@bgdev.pl",
> > +    description="Python bindings for libgpiod",
> > +    platforms=["linux"],
>
> > +    license="LGPLv2.1",
>
> Is it applicable to the bindings only? I am not familiar with the code base,
> but one of the patches in this series makes me wonder if you are not going to
> make same mistake by licensing tools, if any written in pure Python, with a
> wrong license.
>

Every file has its own SPDX identifier that takes precedence anyway.
The module is licensed under LGPLv2.1. The tests and examples are
under GPLv2. The setup.py applies to the importable library so
LGPLv2.1 sounds good to me.

Bart
diff mbox series

Patch

diff --git a/bindings/python/setup.py b/bindings/python/setup.py
index c90d7d7..7ad5de3 100644
--- a/bindings/python/setup.py
+++ b/bindings/python/setup.py
@@ -39,4 +39,9 @@  setup(
     packages=find_packages(include=["gpiod"]),
     ext_modules=extensions,
     version=__version__,
+    author="Bartosz Golaszewski",
+    author_email="brgl@bgdev.pl",
+    description="Python bindings for libgpiod",
+    platforms=["linux"],
+    license="LGPLv2.1",
 )