| Message ID | 20220802110232.130758-1-francesco.dolcini@toradex.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M | expand |
On Tue, Aug 2, 2022 at 1:02 PM Francesco Dolcini <francesco.dolcini@toradex.com> wrote: > Change PINCTRL_IMX8M* dependency from just ARCH_MXC to SOC_IMX8M, > likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting > the config when SOC_IMX8M is not enabled. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > A similar change would be needed for drivers/clk/imx/Kconfig, > in addition to that the other pinctrl are selected by the SOC > (config SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for > IMX8M and these options. > > Not sure what should we do exactly, therefore the RFC tag, I stumbled on this while > slimming down the imx_v6_v7_defconfig for my own needs, and after disabling SOC_IMX8M > all these options were still enabled. No comments for 20 days from the maintainers so resend it as non-RFC, if the maintainers have no comments I guess we apply it and see what happens? Yours, Linus Walleij
> Subject: Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on > SOC_IMX8M > > On Tue, Aug 2, 2022 at 1:02 PM Francesco Dolcini > <francesco.dolcini@toradex.com> wrote: > > > Change PINCTRL_IMX8M* dependency from just ARCH_MXC to > SOC_IMX8M, > > likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting > > the config when SOC_IMX8M is not enabled. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > A similar change would be needed for drivers/clk/imx/Kconfig, in > > addition to that the other pinctrl are selected by the SOC (config > > SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for IMX8M > > and these options. > > > > Not sure what should we do exactly, therefore the RFC tag, I stumbled > > on this while slimming down the imx_v6_v7_defconfig for my own needs, > > and after disabling SOC_IMX8M all these options were still enabled. > > No comments for 20 days from the maintainers so resend it as non-RFC, if > the maintainers have no comments I guess we apply it and see what > happens? Initially SOC_IMX8M* was introduced for some driver under drivers/soc/imx/ for i.MX8M. But it should be fine to let PINCTRL_IMX8M* depends on SOC_IMX8M. Regards, Peng. > > Yours, > Linus Walleij
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index d96b1130efd3..365fcff8e470 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP config PINCTRL_IMX8MM tristate "IMX8MM pinctrl driver" - depends on ARCH_MXC + depends on SOC_IMX8M select PINCTRL_IMX help Say Y here to enable the imx8mm pinctrl driver config PINCTRL_IMX8MN tristate "IMX8MN pinctrl driver" - depends on ARCH_MXC + depends on SOC_IMX8M select PINCTRL_IMX help Say Y here to enable the imx8mn pinctrl driver config PINCTRL_IMX8MP tristate "IMX8MP pinctrl driver" - depends on ARCH_MXC + depends on SOC_IMX8M select PINCTRL_IMX help Say Y here to enable the imx8mp pinctrl driver config PINCTRL_IMX8MQ tristate "IMX8MQ pinctrl driver" - depends on ARCH_MXC + depends on SOC_IMX8M select PINCTRL_IMX help Say Y here to enable the imx8mq pinctrl driver
Change PINCTRL_IMX8M* dependency from just ARCH_MXC to SOC_IMX8M, likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting the config when SOC_IMX8M is not enabled. Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- A similar change would be needed for drivers/clk/imx/Kconfig, in addition to that the other pinctrl are selected by the SOC (config SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for IMX8M and these options. Not sure what should we do exactly, therefore the RFC tag, I stumbled on this while slimming down the imx_v6_v7_defconfig for my own needs, and after disabling SOC_IMX8M all these options were still enabled. --- drivers/pinctrl/freescale/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)