| Message ID | 20220628081709.829811-4-colin.foster@in-advantage.com |
|---|---|
| State | New |
| Headers | show |
| Series | add support for VSC7512 control over SPI | expand |
On Tue, Jun 28, 2022 at 10:17 AM Colin Foster <colin.foster@in-advantage.com> wrote: > > Work is being done to allow external control of Ocelot chips. When pinctrl > drivers are used internally, it wouldn't make much sense to allow them to > be loaded as modules. In the case where the Ocelot chip is controlled > externally, this scenario becomes practical. ... > builtin_platform_driver(ocelot_pinctrl_driver); This contradicts the logic behind this change. Perhaps you need to move to module_platform_driver(). (Yes, I think functionally it won't be any changes if ->remove() is not needed, but for the sake of logical correctness...)
Hi Andy, On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > <colin.foster@in-advantage.com> wrote: > > > > Work is being done to allow external control of Ocelot chips. When pinctrl > > drivers are used internally, it wouldn't make much sense to allow them to > > be loaded as modules. In the case where the Ocelot chip is controlled > > externally, this scenario becomes practical. > > ... > > > builtin_platform_driver(ocelot_pinctrl_driver); > > This contradicts the logic behind this change. Perhaps you need to > move to module_platform_driver(). (Yes, I think functionally it won't > be any changes if ->remove() is not needed, but for the sake of > logical correctness...) I'll do this. Thanks. Process question: If I make this change is it typical to remove all Reviewed-By tags? I assume "yes" > > -- > With Best Regards, > Andy Shevchenko
On Tue, Jun 28, 2022 at 8:25 PM Colin Foster <colin.foster@in-advantage.com> wrote: > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > <colin.foster@in-advantage.com> wrote: ... > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > This contradicts the logic behind this change. Perhaps you need to > > move to module_platform_driver(). (Yes, I think functionally it won't > > be any changes if ->remove() is not needed, but for the sake of > > logical correctness...) > > I'll do this. Thanks. > > Process question: If I make this change is it typical to remove all > Reviewed-By tags? I assume "yes" I would not. This change is logical continuation and I truly believe every reviewer will agree on it.
On Tue, Jun 28, 2022 at 9:00 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Tue, Jun 28, 2022 at 8:25 PM Colin Foster > <colin.foster@in-advantage.com> wrote: > > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > > <colin.foster@in-advantage.com> wrote: > > ... > > > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > > > This contradicts the logic behind this change. Perhaps you need to > > > move to module_platform_driver(). (Yes, I think functionally it won't > > > be any changes if ->remove() is not needed, but for the sake of > > > logical correctness...) > > > > I'll do this. Thanks. > > > > Process question: If I make this change is it typical to remove all > > Reviewed-By tags? I assume "yes" > > I would not. This change is logical continuation and I truly believe > every reviewer will agree on it. I would have to think hard to remember a single review comment from Andy where I didn't think "ah, yeah he's right", so definately keep mine. Yours, Linus Walleij
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index f52960d2dfbe..257b06752747 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -311,7 +311,7 @@ config PINCTRL_MICROCHIP_SGPIO LED controller. config PINCTRL_OCELOT - bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" + tristate "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" depends on OF depends on HAS_IOMEM select GPIOLIB diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 5f4a8c5c6650..5554c3014448 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1889,6 +1889,7 @@ static const struct of_device_id ocelot_pinctrl_of_match[] = { { .compatible = "microchip,lan966x-pinctrl", .data = &lan966x_desc }, {}, }; +MODULE_DEVICE_TABLE(of, ocelot_pinctrl_of_match); static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev) { @@ -1985,3 +1986,6 @@ static struct platform_driver ocelot_pinctrl_driver = { .probe = ocelot_pinctrl_probe, }; builtin_platform_driver(ocelot_pinctrl_driver); + +MODULE_DESCRIPTION("Ocelot Chip Pinctrl Driver"); +MODULE_LICENSE("Dual MIT/GPL");