| Message ID | 20220224043605.26157-1-srinivas.neeli@xilinx.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: zynq: use module_platform_driver to simplify the code | expand |
On Thu, Feb 24, 2022 at 5:36 AM Srinivas Neeli <srinivas.neeli@xilinx.com> wrote: > module_platform_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Nice, patch applied! > -static int __init zynq_pinctrl_init(void) > -{ > - return platform_driver_register(&zynq_pinctrl_driver); > -} > -arch_initcall(zynq_pinctrl_init); > +module_platform_driver(zynq_pinctrl_driver); This will incidentally also move the initcall from arch_initcall to driver_initcall but I assume that works so, OK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c index a96af8a76a7a..0e8de27d0de8 100644 --- a/drivers/pinctrl/pinctrl-zynq.c +++ b/drivers/pinctrl/pinctrl-zynq.c @@ -8,6 +8,7 @@ */ #include <linux/io.h> #include <linux/mfd/syscon.h> +#include <linux/module.h> #include <linux/init.h> #include <linux/of.h> #include <linux/platform_device.h> @@ -1210,8 +1211,4 @@ static struct platform_driver zynq_pinctrl_driver = { .probe = zynq_pinctrl_probe, }; -static int __init zynq_pinctrl_init(void) -{ - return platform_driver_register(&zynq_pinctrl_driver); -} -arch_initcall(zynq_pinctrl_init); +module_platform_driver(zynq_pinctrl_driver);
module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> --- drivers/pinctrl/pinctrl-zynq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)