| Message ID | 20220111140519.1.Ie2662d6289af1e9758b14b37149703c846d5f509@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified | expand |
Quoting Douglas Anderson (2022-01-11 14:05:21) > If the drive-strength isn't specified in the device tree then it > doesn't actually default to 2. Instead, it defaults to whatever the > heck the BIOS left it at. If the BIOS doesn't touch it then that means > it's whatever the heck the initial state of the pin was when the SoC > booted. > > Reported-by: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Tue, Jan 11, 2022 at 02:05:21PM -0800, Douglas Anderson wrote: > If the drive-strength isn't specified in the device tree then it > doesn't actually default to 2. Instead, it defaults to whatever the > heck the BIOS left it at. If the BIOS doesn't touch it then that means > it's whatever the heck the initial state of the pin was when the SoC > booted. > > Reported-by: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Tue, Jan 11, 2022 at 11:05 PM Douglas Anderson <dianders@chromium.org> wrote: > If the drive-strength isn't specified in the device tree then it > doesn't actually default to 2. Instead, it defaults to whatever the > heck the BIOS left it at. If the BIOS doesn't touch it then that means > it's whatever the heck the initial state of the pin was when the SoC > booted. > > Reported-by: Matthias Kaehlcke <mka@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Patch applied. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml index 3b37cf102d41..dac788bc9320 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml @@ -70,7 +70,6 @@ $defs: properties: drive-strength: enum: [2, 4, 6, 8, 10, 12, 14, 16] - default: 2 description: Selects the drive strength for the specified pins, in mA.
If the drive-strength isn't specified in the device tree then it doesn't actually default to 2. Instead, it defaults to whatever the heck the BIOS left it at. If the BIOS doesn't touch it then that means it's whatever the heck the initial state of the pin was when the SoC booted. Reported-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 1 - 1 file changed, 1 deletion(-)