| Message ID | 20211111202506.19459-1-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpiolib: improve coding style for local variables | expand |
On Thu, Nov 11, 2021 at 9:25 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > Drop unneeded whitespaces and put the variables of the same type > together for consistency with the rest of the code. > > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> OK then (also results in inverse christmas-tree shape...) Yours, Linus Walleij
On Thu, Nov 11, 2021 at 9:29 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Nov 11, 2021 at 9:25 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > Drop unneeded whitespaces and put the variables of the same type > > together for consistency with the rest of the code. > > > > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > > OK then (also results in inverse christmas-tree shape...) i.e. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index d1b9b721218f..4c34c96ef136 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -594,11 +594,10 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, struct lock_class_key *request_key) { struct fwnode_handle *fwnode = gc->parent ? dev_fwnode(gc->parent) : NULL; - unsigned long flags; - int ret = 0; - unsigned i; - int base = gc->base; + int ret = 0, base = gc->base; struct gpio_device *gdev; + unsigned long flags; + unsigned int i; /* * First: allocate and populate the internal stat container, and
Drop unneeded whitespaces and put the variables of the same type together for consistency with the rest of the code. Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> --- drivers/gpio/gpiolib.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)