| Message ID | 20211104154135.2119-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | gpio/rockchip: fix Kconfig to prevent build errors | expand |
On Thu, Nov 4, 2021 at 4:41 PM Randy Dunlap <rdunlap@infradead.org> wrote: > GPIO_ROCKCHIP needs to enable GENERIC_IRQ_CHIP to prevent build errors. > > Eliminates these build errors: > ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable': > gpio-rockchip.c:(.text+0x6c9): undefined reference to `irq_gc_mask_set_bit' > ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable': > gpio-rockchip.c:(.text+0x709): undefined reference to `irq_gc_mask_clr_bit' > ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_gpio_probe': > gpio-rockchip.c:(.text+0xe25): undefined reference to `irq_generic_chip_ops' > ld: gpio-rockchip.c:(.text+0xe7e): undefined reference to `__irq_alloc_domain_generic_chips' > ld: gpio-rockchip.c:(.text+0xeb9): undefined reference to `irq_get_domain_generic_chip' > ld: gpio-rockchip.c:(.text+0xf04): undefined reference to `irq_gc_ack_set_bit' > ld: gpio-rockchip.c:(.text+0xf0e): undefined reference to `irq_gc_mask_set_bit' > ld: gpio-rockchip.c:(.text+0xf18): undefined reference to `irq_gc_mask_clr_bit' > ld: gpio-rockchip.c:(.text+0xf36): undefined reference to `irq_gc_set_wake' > > Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jianqun Xu <jay.xu@rock-chips.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: linux-gpio@vger.kernel.org Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
--- linux-next-20211104.orig/drivers/gpio/Kconfig +++ linux-next-20211104/drivers/gpio/Kconfig @@ -524,6 +524,7 @@ config GPIO_ROCKCHIP tristate "Rockchip GPIO support" depends on ARCH_ROCKCHIP || COMPILE_TEST select GPIOLIB_IRQCHIP + select GENERIC_IRQ_CHIP default ARCH_ROCKCHIP help Say yes here to support GPIO on Rockchip SoCs.
GPIO_ROCKCHIP needs to enable GENERIC_IRQ_CHIP to prevent build errors. Eliminates these build errors: ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable': gpio-rockchip.c:(.text+0x6c9): undefined reference to `irq_gc_mask_set_bit' ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable': gpio-rockchip.c:(.text+0x709): undefined reference to `irq_gc_mask_clr_bit' ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_gpio_probe': gpio-rockchip.c:(.text+0xe25): undefined reference to `irq_generic_chip_ops' ld: gpio-rockchip.c:(.text+0xe7e): undefined reference to `__irq_alloc_domain_generic_chips' ld: gpio-rockchip.c:(.text+0xeb9): undefined reference to `irq_get_domain_generic_chip' ld: gpio-rockchip.c:(.text+0xf04): undefined reference to `irq_gc_ack_set_bit' ld: gpio-rockchip.c:(.text+0xf0e): undefined reference to `irq_gc_mask_set_bit' ld: gpio-rockchip.c:(.text+0xf18): undefined reference to `irq_gc_mask_clr_bit' ld: gpio-rockchip.c:(.text+0xf36): undefined reference to `irq_gc_set_wake' Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Jianqun Xu <jay.xu@rock-chips.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Bartosz Golaszewski <brgl@bgdev.pl> Cc: linux-gpio@vger.kernel.org --- drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)