| Message ID | 20211031064046.13533-1-sergio.paracuellos@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c' | expand |
On Sun, Oct 31, 2021 at 8:41 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > declared in ralink_regs.h. > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") > Cc: stable@vger.kernel.org > Cc: linus.walleij@linaro.org > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Tag blocks mustn't have blank lines. ... > +#include <asm/mach-ralink/ralink_regs.h> > #include <asm/mach-ralink/mt7620.h> > #include <linux/module.h> > #include <linux/platform_device.h> Actually the rule of thumb is to start from more generic definitions / inclusions to more particular. Thus, asm/* usually goes after linux/*. Any Specific reason why here is not the case?
Hi Andy, On Sun, Oct 31, 2021 at 2:08 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Oct 31, 2021 at 8:41 AM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: > > > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > > declared in ralink_regs.h. > > > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") > > Cc: stable@vger.kernel.org > > Cc: linus.walleij@linaro.org > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > Tag blocks mustn't have blank lines. Ok, thanks for letting me know. > > ... > > > +#include <asm/mach-ralink/ralink_regs.h> > > #include <asm/mach-ralink/mt7620.h> > > #include <linux/module.h> > > #include <linux/platform_device.h> > > Actually the rule of thumb is to start from more generic definitions / > inclusions to more particular. Thus, asm/* usually goes after linux/*. > Any Specific reason why here is not the case? I just respect the order that was already in the files, I guess when I moved all of this from arch/mips into drivers/pinctrl. All files inside follows the same order. Best regards, Sergio Paracuellos > > -- > With Best Regards, > Andy Shevchenko
On Sun, Oct 31, 2021 at 7:40 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > declared in ralink_regs.h. > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") > Cc: stable@vger.kernel.org > Cc: linus.walleij@linaro.org > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > --- > Changes in v2: > - Original patch from Luiz. > - I have added Fixes tag and CC Linus Walleij and stable and sent v2. Fixed up headers and applied for fixes. Yours, Linus Walleij
On Tue, Nov 9, 2021 at 12:00 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sun, Oct 31, 2021 at 7:40 AM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: > > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > > declared in ralink_regs.h. > > > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") > > Cc: stable@vger.kernel.org > > Cc: linus.walleij@linaro.org > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > Changes in v2: > > - Original patch from Luiz. > > - I have added Fixes tag and CC Linus Walleij and stable and sent v2. > > Fixed up headers and applied for fixes. Thanks! Best regards, Sergio Paracuellos > > Yours, > Linus Walleij
diff --git a/drivers/pinctrl/ralink/pinctrl-mt7620.c b/drivers/pinctrl/ralink/pinctrl-mt7620.c index 425d55a2ee19..6853b5b8b0fe 100644 --- a/drivers/pinctrl/ralink/pinctrl-mt7620.c +++ b/drivers/pinctrl/ralink/pinctrl-mt7620.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only +#include <asm/mach-ralink/ralink_regs.h> #include <asm/mach-ralink/mt7620.h> #include <linux/module.h> #include <linux/platform_device.h>
mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h. Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") Cc: stable@vger.kernel.org Cc: linus.walleij@linaro.org Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- Changes in v2: - Original patch from Luiz. - I have added Fixes tag and CC Linus Walleij and stable and sent v2. drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 + 1 file changed, 1 insertion(+)