| Message ID | 20211005144329.2405315-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: qcom: convert ssbi-mpp and spmi-mpp to hierarchical IRQ | expand |
On Tue, 05 Oct 2021 17:43:25 +0300, Dmitry Baryshkov wrote: > Stop specifying individual interrupts properties. Use #interrupt-cells > instead as we are switching qcom,spmi-mpp and qcom,ssbi-mpp to > hierarchical IRQ setup. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1536696 mpp@50: 'gpio-ranges' is a required property arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml mpp@50: 'interrupt-controller' is a required property arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml mpp@50: 'interrupts' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml mpps@50: 'cm3605-mpps', 'interrupts' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml mpps@50: 'gpio-ranges' is a required property arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml mpps@50: 'interrupt-controller' is a required property arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml mpps@50: 'interrupts' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml mpps@a000: compatible: ['qcom,pm8916-mpp'] is too short arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml mpps@a000: compatible: ['qcom,pm8994-mpp'] is too short arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml mpps@a000: 'gpio-ranges' is a required property arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml mpps@a000: 'interrupt-controller' is a required property arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml mpps@a000: 'interrupts' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml mpps@a000: 'interrupts', 'pm8916-mpp4', 'pm8916-mpps-leds' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml mpps@a000: pm8994-mpps-default-state: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml index 6066857b5964..8a01a9b22e07 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml @@ -40,12 +40,10 @@ properties: reg: maxItems: 1 - interrupts: - minItems: 1 - maxItems: 12 - description: - Must contain an array of encoded interrupt specifiers for - each available MPP + interrupt-controller: true + + '#interrupt-cells': + const: 2 gpio-controller: true gpio-line-names: true @@ -67,6 +65,7 @@ required: - gpio-controller - '#gpio-cells' - gpio-ranges + - interrupt-controller patternProperties: '-state$': @@ -163,7 +162,8 @@ examples: gpio-ranges = <&pm8841_mpp 0 0 4>; gpio-line-names = "VDD_PX_BIAS", "WLAN_LED_CTRL", "BT_LED_CTRL", "GPIO-F"; - interrupts = <4 0xa0 0 0>, <4 0xa1 0 0>, <4 0xa2 0 0>, <4 0xa3 0 0>; + interrupt-controller; + #interrupt-cells = <2>; pinctrl-names = "default"; pinctrl-0 = <&pm8841_default>;
Stop specifying individual interrupts properties. Use #interrupt-cells instead as we are switching qcom,spmi-mpp and qcom,ssbi-mpp to hierarchical IRQ setup. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)