| Message ID | 20210825082251.2484-1-caihuoqing@baidu.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: freescale: Add helper dependency on COMPILE_TEST | expand |
On Wed, Aug 25, 2021 at 10:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote: > it's helpful for complie test in other platform(e.g.X86) > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> It seems weird to only enable this on a few select subdrivers rather than all of the Freescale drivers? (Also: the Freescale maintainers are very silent, some feedback would be helpful.) Yours, Linus Walleij
On 17 9月 21 00:07:32, Linus Walleij wrote: > On Wed, Aug 25, 2021 at 10:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote: > > > it's helpful for complie test in other platform(e.g.X86) > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > > It seems weird to only enable this on a few select subdrivers rather > than all of the Freescale drivers? The others seem to depend on SOC_IMX arch related headers but it's ok for ARCH_IMX related to use COMPILE_TEST. > > (Also: the Freescale maintainers are very silent, some feedback > would be helpful.) > > Yours, > Linus Walleij
Hi Cai, On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote: > > it's helpful for complie test in other platform(e.g.X86) > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/pinctrl/freescale/Kconfig | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig > index 21fa21c6547b..defc1f38efc7 100644 > --- a/drivers/pinctrl/freescale/Kconfig > +++ b/drivers/pinctrl/freescale/Kconfig > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP > > config PINCTRL_IMX8MM > tristate "IMX8MM pinctrl driver" > - depends on ARCH_MXC > + depends on ARCH_MXC || (COMPILE_TEST && OF) > select PINCTRL_IMX I am not sure why you need the && OF, as we have a "select PINCTRL_IMX", that already depends on OF. Also, why was PINCTRL_IMX8DXL not updated? Thanks
On 17 9月 21 08:50:55, Fabio Estevam wrote: > Hi Cai, > > On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote: > > > > it's helpful for complie test in other platform(e.g.X86) > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > > --- > > drivers/pinctrl/freescale/Kconfig | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig > > index 21fa21c6547b..defc1f38efc7 100644 > > --- a/drivers/pinctrl/freescale/Kconfig > > +++ b/drivers/pinctrl/freescale/Kconfig > > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP > > > > config PINCTRL_IMX8MM > > tristate "IMX8MM pinctrl driver" > > - depends on ARCH_MXC > > + depends on ARCH_MXC || (COMPILE_TEST && OF) > > select PINCTRL_IMX > > I am not sure why you need the && OF, as we have a "select PINCTRL_IMX", > that already depends on OF. No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF opened. > > Also, why was PINCTRL_IMX8DXL not updated? Ok, I'll update all pinctrl IMX. > > Thanks
Hi Cai, On Fri, Sep 17, 2021 at 11:26 PM Cai Huoqing <caihuoqing@baidu.com> wrote: > > I am not sure why you need the && OF, as we have a "select PINCTRL_IMX", > > that already depends on OF. > No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF I don't understand your statement. From drivers/pinctrl/freescale/Kconfig: config PINCTRL_IMX tristate depends on OF So PINCTRL_IMX depends on OF, which means that it can only be selected when CONFIG_OF=y.
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index 21fa21c6547b..defc1f38efc7 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP config PINCTRL_IMX8MM tristate "IMX8MM pinctrl driver" - depends on ARCH_MXC + depends on ARCH_MXC || (COMPILE_TEST && OF) select PINCTRL_IMX help Say Y here to enable the imx8mm pinctrl driver config PINCTRL_IMX8MN tristate "IMX8MN pinctrl driver" - depends on ARCH_MXC + depends on ARCH_MXC || (COMPILE_TEST && OF) select PINCTRL_IMX help Say Y here to enable the imx8mn pinctrl driver config PINCTRL_IMX8MP tristate "IMX8MP pinctrl driver" - depends on ARCH_MXC + depends on ARCH_MXC || (COMPILE_TEST && OF) select PINCTRL_IMX help Say Y here to enable the imx8mp pinctrl driver config PINCTRL_IMX8MQ tristate "IMX8MQ pinctrl driver" - depends on ARCH_MXC + depends on ARCH_MXC || (COMPILE_TEST && OF) select PINCTRL_IMX help Say Y here to enable the imx8mq pinctrl driver @@ -168,7 +168,7 @@ config PINCTRL_IMX8DXL config PINCTRL_IMX8ULP tristate "IMX8ULP pinctrl driver" - depends on ARCH_MXC + depends on ARCH_MXC || (COMPILE_TEST && OF) select PINCTRL_IMX help Say Y here to enable the imx8ulp pinctrl driver
it's helpful for complie test in other platform(e.g.X86) Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/pinctrl/freescale/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)