| Message ID | 20210515075905.12150-2-aardelean@deviqon.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpio: gpio-tegra186: remove empty remove hook | expand |
On Sat, May 15, 2021 at 9:59 AM Alexandru Ardelean <aardelean@deviqon.com> wrote: > > The platform_set_drvdata() call is only useful if we need to retrieve back > the private information. > Since the driver doesn't do that, it's not useful to have it. > > If this is removed, we can also just do a direct return on > devm_gpiochip_add_data(). We don't need to print that this call failed as > there are other ways to log/see this during probe. > > Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com> > --- > drivers/gpio/gpio-tegra186.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c > index 10d3597e9ac2..f54ae9d4254a 100644 > --- a/drivers/gpio/gpio-tegra186.c > +++ b/drivers/gpio/gpio-tegra186.c > @@ -741,13 +741,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev) > offset += port->pins; > } > > - platform_set_drvdata(pdev, gpio); > - > - err = devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio); > - if (err < 0) > - return err; > - > - return 0; > + return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio); > } > > #define TEGRA186_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \ > -- > 2.31.1 > Normally I'd wait for Thierry's Ack but this cleanup is pretty straightforward so I applied both patches. Bart
diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c index 10d3597e9ac2..f54ae9d4254a 100644 --- a/drivers/gpio/gpio-tegra186.c +++ b/drivers/gpio/gpio-tegra186.c @@ -741,13 +741,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev) offset += port->pins; } - platform_set_drvdata(pdev, gpio); - - err = devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio); - if (err < 0) - return err; - - return 0; + return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio, gpio); } #define TEGRA186_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \
The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe. Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com> --- drivers/gpio/gpio-tegra186.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)