diff mbox series

[1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe()

Message ID 20210511100646.5156-1-thunder.leizhen@huawei.com
State New
Headers show
Series [1/1] gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe() | expand

Commit Message

Zhen Lei May 11, 2021, 10:06 a.m. UTC
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/gpio/gpio-logicvc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Bartosz Golaszewski May 12, 2021, 11:38 a.m. UTC | #1
On Tue, May 11, 2021 at 12:07 PM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/gpio/gpio-logicvc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
> index 015632cf159f0b8..992cc958a43fd1e 100644
> --- a/drivers/gpio/gpio-logicvc.c
> +++ b/drivers/gpio/gpio-logicvc.c
> @@ -114,10 +114,8 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
>                 }
>
>                 base = devm_ioremap_resource(dev, &res);
> -               if (IS_ERR(base)) {
> -                       dev_err(dev, "Failed to map I/O base\n");
> +               if (IS_ERR(base))
>                         return PTR_ERR(base);
> -               }
>
>                 logicvc_gpio_regmap_config.max_register = resource_size(&res) -
>                         logicvc_gpio_regmap_config.reg_stride;
> --
> 2.26.0.106.g9fadedd
>
>

Applied, thanks!

Bartosz
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
index 015632cf159f0b8..992cc958a43fd1e 100644
--- a/drivers/gpio/gpio-logicvc.c
+++ b/drivers/gpio/gpio-logicvc.c
@@ -114,10 +114,8 @@  static int logicvc_gpio_probe(struct platform_device *pdev)
 		}
 
 		base = devm_ioremap_resource(dev, &res);
-		if (IS_ERR(base)) {
-			dev_err(dev, "Failed to map I/O base\n");
+		if (IS_ERR(base))
 			return PTR_ERR(base);
-		}
 
 		logicvc_gpio_regmap_config.max_register = resource_size(&res) -
 			logicvc_gpio_regmap_config.reg_stride;