From patchwork Wed Mar 10 17:43:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 1450661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qQNgkKka; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DwfbD4Cxhz9sWW for ; Thu, 11 Mar 2021 04:44:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232065AbhCJRns (ORCPT ); Wed, 10 Mar 2021 12:43:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhCJRnS (ORCPT ); Wed, 10 Mar 2021 12:43:18 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0A2C061760 for ; Wed, 10 Mar 2021 09:43:18 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo11248494wmq.4 for ; Wed, 10 Mar 2021 09:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QVRp3XgdEf96v7bzdf/9udqO1z6/YKzarZhSzPUl2Ao=; b=qQNgkKkaoVuUb8svFTJfxDaCJw+KYrPfZ4DjT5xDAeg6PDddio33O0CtuYm6nTYR4y cSCCXEmy3S32fkBMfB/hFoJv1Bqt53M6NyOBMWF+8iFEf8Na8T7rXZ7FjdsfkwOGSDih jkjX2968pOr5lSbyFAMg0eMti6gE51hbQxx6ewxOMu67bxvU1Ouc8JFgbZsOeA6bw9QB XX9aNBhUeUkJuF7l06dtLz15DIGADdgq47TNXfFt1DM2kHcJuWn+rKmxjjRY0IhELP1M OWxsTMBu8J5VxfmrGdpAH7Hlr61AZaseHBrdWLFdE9dtVgX3hvL0zAn27YLT7+6hrThK XwEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QVRp3XgdEf96v7bzdf/9udqO1z6/YKzarZhSzPUl2Ao=; b=LDPVIzxJgFNiLXbZkfSuZEaAxeVXixDKWBFLD6PMgQZaGPCcHX4JE8DydxxZjhxdVG 6U88w6pKHyVcaPeRYWVtW6VAMi8yH8WreuDqp/Kysw4ER9HHujzSiT2m6OzQUFrg9q7Y 1SDrfrX8yh5xeplEpkzUIzmbsNwHfl58aY8zR34fQWjcimhqUOgUlPJs2GwFpIeuTkNg 2rt4rcbtNcG5HLLk/+RToSz4ZfP1mYNu9kzJ7fJlmAZVkqf1mxepGcEc8t7YdcxmVIs4 qt3bjHIgJsvHtNeFCC8wO5ZiDeG78Yf52jqbQ2p3CXmlAGtOuinGfR5lem6usJS1b2IZ RzSA== X-Gm-Message-State: AOAM533JwRU9aSSoCfQkmFplg/FxDnS2NZMmqIC70Oqdh34uWK2216a5 sD7nQD8NIXFP8sXkXb1l02twLg== X-Google-Smtp-Source: ABdhPJxDHNp6Whpz1hiBgu5T6d+44kp1IWNIJGT0ruD2WXDrYgnHL1NxCazodV1ym8YBs6ql05WYKg== X-Received: by 2002:a05:600c:210a:: with SMTP id u10mr4528031wml.147.1615398197012; Wed, 10 Mar 2021 09:43:17 -0800 (PST) Received: from srini-hackbox.lan (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.gmail.com with ESMTPSA id x13sm24371wrt.75.2021.03.10.09.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 09:43:16 -0800 (PST) From: Srinivas Kandagatla To: linus.walleij@linaro.org, linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, amit.pundir@linaro.org, bjorn.andersson@linaro.org, Srinivas Kandagatla , Andy Shevchenko Subject: [PATCH v2] gpio: wcd934x: Fix shift-out-of-bounds error Date: Wed, 10 Mar 2021 17:43:04 +0000 Message-Id: <20210310174304.22176-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org bit-mask for pins 0 to 4 is BIT(0) to BIT(4) however we ended up with BIT(n - 1) which is not right, and this was caught by below usban check UBSAN: shift-out-of-bounds in drivers/gpio/gpio-wcd934x.c:34:14 Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller") Signed-off-by: Srinivas Kandagatla Reviewed-by: Andy Shevchenko Reviewed-by: Bjorn Andersson --- changes since v1: - removed unnecessary dump stack from log drivers/gpio/gpio-wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 1cbce5990855..97e6caedf1f3 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -7,7 +7,7 @@ #include #include -#define WCD_PIN_MASK(p) BIT(p - 1) +#define WCD_PIN_MASK(p) BIT(p) #define WCD_REG_DIR_CTL_OFFSET 0x42 #define WCD_REG_VAL_CTL_OFFSET 0x43 #define WCD934X_NPINS 5