| Message ID | 20210120050342.320704-1-drew@beagleboard.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: clarify #pinctrl-cells for pinctrl-single,pins | expand |
On Tue, 19 Jan 2021 21:03:44 -0800 Drew Fustini <drew@beagleboard.org> wrote: > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins > > Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") > Reported-by: Emmanuel Vadot <manu@bidouilliste.com> > Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/ > Cc: Tony Lindgren <tony@atomide.com> > Signed-off-by: Drew Fustini <drew@beagleboard.org> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt > index f903eb4471f8..bb9999119314 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt > @@ -8,7 +8,7 @@ Required properties: > - reg : offset and length of the register set for the mux registers > > - #pinctrl-cells : number of cells in addition to the index, set to 1 > - for pinctrl-single,pins and 2 for pinctrl-single,bits > + or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits > > - pinctrl-single,register-width : pinmux register access width in bits > > -- > 2.25.1 > Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org> Thanks, now the docs make more sense :)
* Emmanuel Vadot <manu@bidouilliste.com> [210120 08:01]: > On Tue, 19 Jan 2021 21:03:44 -0800 > Drew Fustini <drew@beagleboard.org> wrote: > > > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins ... > Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org> > > Thanks, now the docs make more sense :) Looks good to me too: Reviewed-by: Tony Lindgren <tony@atomide.com>
On Wed, Jan 20, 2021 at 6:04 AM Drew Fustini <drew@beagleboard.org> wrote: > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins > > Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") > Reported-by: Emmanuel Vadot <manu@bidouilliste.com> > Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/ > Cc: Tony Lindgren <tony@atomide.com> > Signed-off-by: Drew Fustini <drew@beagleboard.org> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt index f903eb4471f8..bb9999119314 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt @@ -8,7 +8,7 @@ Required properties: - reg : offset and length of the register set for the mux registers - #pinctrl-cells : number of cells in addition to the index, set to 1 - for pinctrl-single,pins and 2 for pinctrl-single,bits + or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits - pinctrl-single,register-width : pinmux register access width in bits
Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") Reported-by: Emmanuel Vadot <manu@bidouilliste.com> Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/ Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Drew Fustini <drew@beagleboard.org> --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)