| Message ID | 20201015115903.2a782f78@xhacker.debian |
|---|---|
| State | New |
| Headers | show |
| Series | remove never-used "snps,dw-apb-gpio-port" | expand |
On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > The compatible string is never used. Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this: make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > --- > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index 1240f6289249..76e7b07d592f 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -50,9 +50,6 @@ patternProperties: > "^gpio-(port|controller)@[0-9a-f]+$": > type: object > properties: > - compatible: > - const: snps,dw-apb-gpio-port > - Yep, you've removed the "compatible" property but forgot to do the same from the "required:" property of the sub-nodes schema. That's why the suggested make-command above would have failed during the DT schema examples validation if you ran it. Please, fix it and resend the series. > reg: > maxItems: 1 Yeah. Here I've forgotten to add the "reg" property constraints. Since certainly the controller won't have more than four sub-nodes by design, could you add one in an additional patch of the series since you'll need to resend the patchset anyway? Like this: reg: - maxItems: 1 + minimum: 0 + maximum: 3 -Sergey > > @@ -111,7 +108,6 @@ examples: > #size-cells = <0>; > > porta: gpio-port@0 { > - compatible = "snps,dw-apb-gpio-port"; > reg = <0>; > gpio-controller; > #gpio-cells = <2>; > @@ -123,7 +119,6 @@ examples: > }; > > portb: gpio-port@1 { > - compatible = "snps,dw-apb-gpio-port"; > reg = <1>; > gpio-controller; > #gpio-cells = <2>; > -- > 2.28.0 >
On Thu, Oct 15, 2020 at 3:33 PM Serge Semin <fancer.lancer@gmail.com> wrote: > On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > > The compatible string is never used. > > Before sending v2 could you run "make dt_binding_check" for the DT schema > modified in this patch? Like this: > > make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml Do you really need to install all cross compilation tools for that? I think it should simple work as % make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
On Fri, Oct 16, 2020 at 05:43:08PM +0300, Andy Shevchenko wrote: > On Thu, Oct 15, 2020 at 3:33 PM Serge Semin <fancer.lancer@gmail.com> wrote: > > On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > > > The compatible string is never used. > > > > Before sending v2 could you run "make dt_binding_check" for the DT schema > > modified in this patch? Like this: > > > > make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > > Do you really need to install all cross compilation tools for that? > I think it should simple work as > > % make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml Of course you don't. I just cited my normal command. Your version should be enough to perform the bindings file validation. Note that there are host tools/libs requirements, which need to be satisfied to make that command working. See the next file for details: Documentation/devicetree/writing-schema.rst -Sergey > > -- > With Best Regards, > Andy Shevchenko
diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml index 1240f6289249..76e7b07d592f 100644 --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml @@ -50,9 +50,6 @@ patternProperties: "^gpio-(port|controller)@[0-9a-f]+$": type: object properties: - compatible: - const: snps,dw-apb-gpio-port - reg: maxItems: 1 @@ -111,7 +108,6 @@ examples: #size-cells = <0>; porta: gpio-port@0 { - compatible = "snps,dw-apb-gpio-port"; reg = <0>; gpio-controller; #gpio-cells = <2>; @@ -123,7 +119,6 @@ examples: }; portb: gpio-port@1 { - compatible = "snps,dw-apb-gpio-port"; reg = <1>; gpio-controller; #gpio-cells = <2>;
The compatible string is never used. Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> --- Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 ----- 1 file changed, 5 deletions(-)