| Message ID | 20200412013352.674506-2-aford173@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpiolib: of: Improve gpiolib-of support pull up/down on expanders | expand |
niedz., 12 kwi 2020 o 03:34 Adam Ford <aford173@gmail.com> napisał(a): > > pca953x_gpio_set_config is setup to support pull-up/down > bias. Currently the driver uses a variable called 'config' to > determine which options to use. Unfortunately, this is incorrect. > > This patch uses function pinconf_to_config_param(config), which > converts this 'config' parameter back to pinconfig to determine > which option to use. > > Fixes: 15add06841a3 ("gpio: pca953x: add ->set_config implementation") > > Signed-off-by: Adam Ford <aford173@gmail.com> > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 5638b4e5355f..4269ea9a817e 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -531,7 +531,7 @@ static int pca953x_gpio_set_config(struct gpio_chip *gc, unsigned int offset, > { > struct pca953x_chip *chip = gpiochip_get_data(gc); > > - switch (config) { > + switch (pinconf_to_config_param(config)) { > case PIN_CONFIG_BIAS_PULL_UP: > case PIN_CONFIG_BIAS_PULL_DOWN: > return pca953x_gpio_set_pull_up_down(chip, offset, config); > -- > 2.25.1 > Patch applied for fixes, thanks! Bart
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 5638b4e5355f..4269ea9a817e 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -531,7 +531,7 @@ static int pca953x_gpio_set_config(struct gpio_chip *gc, unsigned int offset, { struct pca953x_chip *chip = gpiochip_get_data(gc); - switch (config) { + switch (pinconf_to_config_param(config)) { case PIN_CONFIG_BIAS_PULL_UP: case PIN_CONFIG_BIAS_PULL_DOWN: return pca953x_gpio_set_pull_up_down(chip, offset, config);
pca953x_gpio_set_config is setup to support pull-up/down bias. Currently the driver uses a variable called 'config' to determine which options to use. Unfortunately, this is incorrect. This patch uses function pinconf_to_config_param(config), which converts this 'config' parameter back to pinconfig to determine which option to use. Fixes: 15add06841a3 ("gpio: pca953x: add ->set_config implementation") Signed-off-by: Adam Ford <aford173@gmail.com>