| Message ID | 20200409141228.49561-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: dwapb: Clean up the driver and a fix | expand |
On Thu, Apr 09, 2020 at 05:12:16PM +0300, Andy Shevchenko wrote: > The commit 3d2613c4289f > ("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver") > introduced a use of the platform driver but missed to add the following line > to it: > MODULE_ALIAS("platform:gpio-dwapb"); > > Add this to get driver loaded automatically if platform device is registered. Looks good. Thanks. Reviewed-by: Serge Semin <fancer.lancer@gmail.com> > > Fixes: 3d2613c4289f ("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-dwapb.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > index d2ed11510f3c..c1b6d4f7307e 100644 > --- a/drivers/gpio/gpio-dwapb.c > +++ b/drivers/gpio/gpio-dwapb.c > @@ -49,7 +49,9 @@ > #define GPIO_EXT_PORTC 0x58 > #define GPIO_EXT_PORTD 0x5c > > +#define DWAPB_DRIVER_NAME "gpio-dwapb" > #define DWAPB_MAX_PORTS 4 > + > #define GPIO_EXT_PORT_STRIDE 0x04 /* register stride 32 bits */ > #define GPIO_SWPORT_DR_STRIDE 0x0c /* register stride 3*32 bits */ > #define GPIO_SWPORT_DDR_STRIDE 0x0c /* register stride 3*32 bits */ > @@ -400,7 +402,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, > return; > > err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 2, > - "gpio-dwapb", handle_level_irq, > + DWAPB_DRIVER_NAME, handle_level_irq, > IRQ_NOREQUEST, 0, > IRQ_GC_INIT_NESTED_LOCK); > if (err) { > @@ -457,7 +459,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, > */ > err = devm_request_irq(gpio->dev, pp->irq[0], > dwapb_irq_handler_mfd, > - IRQF_SHARED, "gpio-dwapb-mfd", gpio); > + IRQF_SHARED, DWAPB_DRIVER_NAME, gpio); > if (err) { > dev_err(gpio->dev, "error requesting IRQ\n"); > irq_domain_remove(gpio->domain); > @@ -847,7 +849,7 @@ static SIMPLE_DEV_PM_OPS(dwapb_gpio_pm_ops, dwapb_gpio_suspend, > > static struct platform_driver dwapb_gpio_driver = { > .driver = { > - .name = "gpio-dwapb", > + .name = DWAPB_DRIVER_NAME, > .pm = &dwapb_gpio_pm_ops, > .of_match_table = of_match_ptr(dwapb_of_match), > .acpi_match_table = ACPI_PTR(dwapb_acpi_match), > @@ -861,3 +863,4 @@ module_platform_driver(dwapb_gpio_driver); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Jamie Iles"); > MODULE_DESCRIPTION("Synopsys DesignWare APB GPIO driver"); > +MODULE_ALIAS("platform:" DWAPB_DRIVER_NAME); > -- > 2.25.1 >
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index d2ed11510f3c..c1b6d4f7307e 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -49,7 +49,9 @@ #define GPIO_EXT_PORTC 0x58 #define GPIO_EXT_PORTD 0x5c +#define DWAPB_DRIVER_NAME "gpio-dwapb" #define DWAPB_MAX_PORTS 4 + #define GPIO_EXT_PORT_STRIDE 0x04 /* register stride 32 bits */ #define GPIO_SWPORT_DR_STRIDE 0x0c /* register stride 3*32 bits */ #define GPIO_SWPORT_DDR_STRIDE 0x0c /* register stride 3*32 bits */ @@ -400,7 +402,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, return; err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 2, - "gpio-dwapb", handle_level_irq, + DWAPB_DRIVER_NAME, handle_level_irq, IRQ_NOREQUEST, 0, IRQ_GC_INIT_NESTED_LOCK); if (err) { @@ -457,7 +459,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, */ err = devm_request_irq(gpio->dev, pp->irq[0], dwapb_irq_handler_mfd, - IRQF_SHARED, "gpio-dwapb-mfd", gpio); + IRQF_SHARED, DWAPB_DRIVER_NAME, gpio); if (err) { dev_err(gpio->dev, "error requesting IRQ\n"); irq_domain_remove(gpio->domain); @@ -847,7 +849,7 @@ static SIMPLE_DEV_PM_OPS(dwapb_gpio_pm_ops, dwapb_gpio_suspend, static struct platform_driver dwapb_gpio_driver = { .driver = { - .name = "gpio-dwapb", + .name = DWAPB_DRIVER_NAME, .pm = &dwapb_gpio_pm_ops, .of_match_table = of_match_ptr(dwapb_of_match), .acpi_match_table = ACPI_PTR(dwapb_acpi_match), @@ -861,3 +863,4 @@ module_platform_driver(dwapb_gpio_driver); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Jamie Iles"); MODULE_DESCRIPTION("Synopsys DesignWare APB GPIO driver"); +MODULE_ALIAS("platform:" DWAPB_DRIVER_NAME);
The commit 3d2613c4289f ("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver") introduced a use of the platform driver but missed to add the following line to it: MODULE_ALIAS("platform:gpio-dwapb"); Add this to get driver loaded automatically if platform device is registered. Fixes: 3d2613c4289f ("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-dwapb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)