Message ID | 20200228063429.47528-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers | show |
Series | [v2,-next] pinctrl: da9062: Fix error gpiolib.h path | expand |
Hi YueHaibing, thanks for covering that and sorry for that bug. Didn't covered that because I'm using a newer toolchain. On 20-02-28 14:34, YueHaibing wrote: > gcc 7.4.0 build fails: > > drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory > #include <../gpio/gpiolib.h> > ^~~~~~~~~~~~~~~~~~~ > > Fix this wrong include path. nit, the path isn't wrong. Whats wrong is the syntax. Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: Fix wrong path > --- > drivers/pinctrl/pinctrl-da9062.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c > index f704ee0b2fd9..c15eb6e99bc1 100644 > --- a/drivers/pinctrl/pinctrl-da9062.c > +++ b/drivers/pinctrl/pinctrl-da9062.c > @@ -25,7 +25,7 @@ > * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if > * the gpio is active low without a vendor specific dt-binding. > */ > -#include <../gpio/gpiolib.h> > +#include "../gpio/gpiolib.h" > > #define DA9062_TYPE(offset) (4 * (offset % 2)) > #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2)) > -- > 2.17.1 > > >
On Fri, Feb 28, 2020 at 7:35 AM YueHaibing <yuehaibing@huawei.com> wrote: > gcc 7.4.0 build fails: > > drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory > #include <../gpio/gpiolib.h> > ^~~~~~~~~~~~~~~~~~~ > > Fix this wrong include path. > > Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: Fix wrong path Good catch! Patch applied with Marco's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c index f704ee0b2fd9..c15eb6e99bc1 100644 --- a/drivers/pinctrl/pinctrl-da9062.c +++ b/drivers/pinctrl/pinctrl-da9062.c @@ -25,7 +25,7 @@ * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if * the gpio is active low without a vendor specific dt-binding. */ -#include <../gpio/gpiolib.h> +#include "../gpio/gpiolib.h" #define DA9062_TYPE(offset) (4 * (offset % 2)) #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
gcc 7.4.0 build fails: drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory #include <../gpio/gpiolib.h> ^~~~~~~~~~~~~~~~~~~ Fix this wrong include path. Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: Fix wrong path --- drivers/pinctrl/pinctrl-da9062.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)