| Message ID | 20190910152855.111588-1-paul.kocialkowski@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] gpio: syscon: Add support for a custom get operation | expand |
On Tue, Sep 10, 2019 at 4:29 PM Paul Kocialkowski <paul.kocialkowski@bootlin.com> wrote: > Some drivers might need a custom get operation to match custom > behavior implemented in the set operation. > > Add plumbing for supporting that. > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Looks OK but as noted in the other patch: we are accumulating stuff in this driver, possibly this syscon part should just be a library used by individual drivers that can be switched on/off with Kconfig. Yours, Linus Walleij
Hi, On Thu 12 Sep 19, 10:18, Linus Walleij wrote: > On Tue, Sep 10, 2019 at 4:29 PM Paul Kocialkowski > <paul.kocialkowski@bootlin.com> wrote: > > > Some drivers might need a custom get operation to match custom > > behavior implemented in the set operation. > > > > Add plumbing for supporting that. > > > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Looks OK but as noted in the other patch: we are accumulating stuff > in this driver, possibly this syscon part should just be a library > used by individual drivers that can be switched on/off with Kconfig. Looks like adding support for a custom get operation would be good to have before moving to a library then :) Cheers, Paul
diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 31f332074d7d..05c537ed73f1 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -43,8 +43,9 @@ struct syscon_gpio_data { unsigned int bit_count; unsigned int dat_bit_offset; unsigned int dir_bit_offset; - void (*set)(struct gpio_chip *chip, - unsigned offset, int value); + int (*get)(struct gpio_chip *chip, unsigned offset); + void (*set)(struct gpio_chip *chip, unsigned offset, + int value); }; struct syscon_gpio_priv { @@ -252,7 +253,7 @@ static int syscon_gpio_probe(struct platform_device *pdev) priv->chip.label = dev_name(dev); priv->chip.base = -1; priv->chip.ngpio = priv->data->bit_count; - priv->chip.get = syscon_gpio_get; + priv->chip.get = priv->data->get ? : syscon_gpio_get; if (priv->data->flags & GPIO_SYSCON_FEAT_IN) priv->chip.direction_input = syscon_gpio_dir_in; if (priv->data->flags & GPIO_SYSCON_FEAT_OUT) {
Some drivers might need a custom get operation to match custom behavior implemented in the set operation. Add plumbing for supporting that. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> --- drivers/gpio/gpio-syscon.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)