| Message ID | 20190621202043.95967-1-natechancellor@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: qcom: sdm845: Fix CONFIG preprocessor guard | expand |
On Fri, 2019-06-21 at 13:20 -0700, Nathan Chancellor wrote:
> Clang warns when CONFIG_ACPI is unset:
Any of these others need the same s/#if/#ifdef/ ?
$ git grep -P '^\s*#\s*if\s+CONFIG_[A-Z0-9_]+\s*$' *
arch/microblaze/include/asm/exceptions.h:#if CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR
arch/microblaze/include/asm/hash.h:#if CONFIG_XILINX_MICROBLAZE0_USE_BARREL
arch/microblaze/include/asm/irqflags.h:#if CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR
arch/microblaze/kernel/entry-nommu.S:#if CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR
arch/microblaze/kernel/entry.S:#if CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR
arch/microblaze/kernel/entry.S:#if CONFIG_MANUAL_RESET_VECTOR
arch/microblaze/kernel/setup.c:#if CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR
arch/powerpc/platforms/powernv/pci.c:#if CONFIG_EEH
arch/x86/boot/compressed/misc.c:#if CONFIG_X86_NEED_RELOCS
arch/x86/boot/compressed/misc.h:#if CONFIG_RANDOMIZE_BASE
drivers/pinctrl/qcom/pinctrl-sdm845.c:#if CONFIG_ACPI
kernel/futex.c:#if CONFIG_BASE_SMALL
On Fri, Jun 21, 2019 at 1:21 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns when CONFIG_ACPI is unset: > > drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is > not defined, evaluates to 0 [-Wundef] > #if CONFIG_ACPI > ^ > 1 warning generated. > > Use ifdef instead of if to resolve this. > > Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") > Link: https://github.com/ClangBuiltLinux/linux/issues/569 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Thanks for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/pinctrl/qcom/pinctrl-sdm845.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c > index 06790e5ece6c..39f498c09906 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c > +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c > @@ -1317,7 +1317,7 @@ static int sdm845_pinctrl_probe(struct platform_device *pdev) > return ret; > } > > -#if CONFIG_ACPI > +#ifdef CONFIG_ACPI Thanks, ~Nick Desaulniers
On Fri, 21 Jun 2019, Nick Desaulniers wrote: > On Fri, Jun 21, 2019 at 1:21 PM Nathan Chancellor > <natechancellor@gmail.com> wrote: > > > > Clang warns when CONFIG_ACPI is unset: > > > > drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is > > not defined, evaluates to 0 [-Wundef] > > #if CONFIG_ACPI > > ^ > > 1 warning generated. > > > > Use ifdef instead of if to resolve this. > > > > Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") > > Link: https://github.com/ClangBuiltLinux/linux/issues/569 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Thanks for the patch. > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Interesting. Thanks for fixing. Acked-by: Lee Jones <lee.jones@linaro.org>
On Fri, Jun 21, 2019 at 10:21 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > Clang warns when CONFIG_ACPI is unset: > > drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is > not defined, evaluates to 0 [-Wundef] > #if CONFIG_ACPI > ^ > 1 warning generated. > > Use ifdef instead of if to resolve this. > > Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") > Link: https://github.com/ClangBuiltLinux/linux/issues/569 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Patch applied with the ACKs. I'm sure Bjorn doesn't mind. Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c index 06790e5ece6c..39f498c09906 100644 --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c @@ -1317,7 +1317,7 @@ static int sdm845_pinctrl_probe(struct platform_device *pdev) return ret; } -#if CONFIG_ACPI +#ifdef CONFIG_ACPI static const struct acpi_device_id sdm845_pinctrl_acpi_match[] = { { "QCOM0217"}, { },
Clang warns when CONFIG_ACPI is unset: drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is not defined, evaluates to 0 [-Wundef] #if CONFIG_ACPI ^ 1 warning generated. Use ifdef instead of if to resolve this. Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") Link: https://github.com/ClangBuiltLinux/linux/issues/569 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/pinctrl/qcom/pinctrl-sdm845.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)