| Message ID | 20190620183037.29652-1-alexandre.belloni@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] pinctrl: ocelot: fix gpio direction for pins after 31 | expand |
On Thu, Jun 20, 2019 at 8:30 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > The third argument passed to REG is not the correct one and > ocelot_gpio_set_direction is not working for pins after 31. Fix that by > passing the pin number instead of the modulo 32 value. > > Fixes: da801ab56ad8 pinctrl: ocelot: add MSCC Jaguar2 support > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 3b4ca52d2456..d2478db975bd 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -432,7 +432,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev, struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); unsigned int p = pin % 32; - regmap_update_bits(info->map, REG(OCELOT_GPIO_OE, info, p), BIT(p), + regmap_update_bits(info->map, REG(OCELOT_GPIO_OE, info, pin), BIT(p), input ? 0 : BIT(p)); return 0;
The third argument passed to REG is not the correct one and ocelot_gpio_set_direction is not working for pins after 31. Fix that by passing the pin number instead of the modulo 32 value. Fixes: da801ab56ad8 pinctrl: ocelot: add MSCC Jaguar2 support Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/pinctrl/pinctrl-ocelot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)