| Message ID | 20190428150822.13935-1-j.neuschaefer@gmx.net |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: Fix spelling of bias-pull-up | expand |
On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote: > The property is spelled 'bias-pull-up', as documented in > pinctrl-bindings.txt. > I also sent out a patch for that... back in 2017: https://patchwork.ozlabs.org/patch/763151/ It's marked Accepted and Archived. @rob ? > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +- > .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +- > .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +- > .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +- > .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt > index c2dbb3e8d840..4e90ddd77784 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt > @@ -42,7 +42,7 @@ information about e.g. the mux function. > The following generic properties as defined in pinctrl-bindings.txt are valid > to specify in a pin configuration subnode: > > - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, > + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, > output-low, output-high. > > Non-empty subnodes must specify the 'pins' property. > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt > index 991be0cd0948..84be0f2c6f3b 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt > @@ -44,7 +44,7 @@ information about e.g. the mux function. > > The following generic properties as defined in pinctrl-bindings.txt are valid > to specify in a pin configuration subnode: > - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength. > + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength. > > Non-empty subnodes must specify the 'pins' property. > Note that not all properties are valid for all pins. > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt > index 7ed56a1b70fc..a7aaaa7db83b 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt > @@ -42,7 +42,7 @@ information about e.g. the mux function. > The following generic properties as defined in pinctrl-bindings.txt are valid > to specify in a pin configuration subnode: > > - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, > + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, > output-low, output-high. > > Non-empty subnodes must specify the 'pins' property. > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt > index cdc4787e59d2..f095209848c8 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt > @@ -42,7 +42,7 @@ information about e.g. the mux function. > The following generic properties as defined in pinctrl-bindings.txt are valid > to specify in a pin configuration subnode: > > - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, > + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, > output-low, output-high. > > Non-empty subnodes must specify the 'pins' property. > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt > index c22e6c425d0b..004056506679 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt > @@ -41,7 +41,7 @@ information about e.g. the mux function. > > The following generic properties as defined in pinctrl-bindings.txt are valid > to specify in a pin configuration subnode: > - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength. > + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength. > > Non-empty subnodes must specify the 'pins' property. > Note that not all properties are valid for all pins. > -- > 2.20.1 >
On Tue, Apr 30, 2019 at 11:32:17PM +0200, Christian Lamparter wrote: > On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote: > > The property is spelled 'bias-pull-up', as documented in > > pinctrl-bindings.txt. > > > > I also sent out a patch for that... back in 2017: > > https://patchwork.ozlabs.org/patch/763151/ > > It's marked Accepted and Archived. > > @rob ? No idea what happened besides a problem between the screen and keyboard. Let me try again... Rob
On Sun, Apr 28, 2019 at 5:08 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > The property is spelled 'bias-pull-up', as documented in > pinctrl-bindings.txt. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> It appears from Rob's comment that he's applying it, tell me if I need to apply it to the pinctrl tree. Yours, Linus Walleij
On Thu, May 16, 2019 at 02:44:30PM +0200, Linus Walleij wrote: > On Sun, Apr 28, 2019 at 5:08 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > > The property is spelled 'bias-pull-up', as documented in > > pinctrl-bindings.txt. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > It appears from Rob's comment that he's applying it, > tell me if I need to apply it to the pinctrl tree. Yes, Rob applied Christian's version to dt/next: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=c50495aa4cfcaace5f61174ab3069d5047d14f17 So there's no need to apply my version. Thanks, Jonathan Neuschäfer
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt index c2dbb3e8d840..4e90ddd77784 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt @@ -42,7 +42,7 @@ information about e.g. the mux function. The following generic properties as defined in pinctrl-bindings.txt are valid to specify in a pin configuration subnode: - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, output-low, output-high. Non-empty subnodes must specify the 'pins' property. diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt index 991be0cd0948..84be0f2c6f3b 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt @@ -44,7 +44,7 @@ information about e.g. the mux function. The following generic properties as defined in pinctrl-bindings.txt are valid to specify in a pin configuration subnode: - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength. + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength. Non-empty subnodes must specify the 'pins' property. Note that not all properties are valid for all pins. diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt index 7ed56a1b70fc..a7aaaa7db83b 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt @@ -42,7 +42,7 @@ information about e.g. the mux function. The following generic properties as defined in pinctrl-bindings.txt are valid to specify in a pin configuration subnode: - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, output-low, output-high. Non-empty subnodes must specify the 'pins' property. diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt index cdc4787e59d2..f095209848c8 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt @@ -42,7 +42,7 @@ information about e.g. the mux function. The following generic properties as defined in pinctrl-bindings.txt are valid to specify in a pin configuration subnode: - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength, + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength, output-low, output-high. Non-empty subnodes must specify the 'pins' property. diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt index c22e6c425d0b..004056506679 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt @@ -41,7 +41,7 @@ information about e.g. the mux function. The following generic properties as defined in pinctrl-bindings.txt are valid to specify in a pin configuration subnode: - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength. + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength. Non-empty subnodes must specify the 'pins' property. Note that not all properties are valid for all pins.
The property is spelled 'bias-pull-up', as documented in pinctrl-bindings.txt. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +- .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +- .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +- .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +- .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- 2.20.1