diff mbox series

[v1,3/3] gpio: 74x164: Convert to use SPDX identifier

Message ID 20190322203322.79881-3-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v1,1/3] gpio: 74x164: Make use of device properties | expand

Commit Message

Andy Shevchenko March 22, 2019, 8:33 p.m. UTC
Reduce size of duplicated comments by switching to use SPDX identifier.

No functional change.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-74x164.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Bartosz Golaszewski March 25, 2019, 8:30 a.m. UTC | #1
pt., 22 mar 2019 o 21:33 Andy Shevchenko
<andriy.shevchenko@linux.intel.com> napisał(a):
>
> Reduce size of duplicated comments by switching to use SPDX identifier.
>
> No functional change.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpio-74x164.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index fbd8478dae3d..1562da217fb5 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0

It should now be: GPL-2.0-only

Bart

>  /*
>   *  74Hx164 - Generic serial-in/parallel-out 8-bits shift register GPIO driver
>   *
>   *  Copyright (C) 2010 Gabor Juhos <juhosg@openwrt.org>
>   *  Copyright (C) 2010 Miguel Gaio <miguel.gaio@efixo.com>
> - *
> - *  This program is free software; you can redistribute it and/or modify
> - *  it under the terms of the GNU General Public License version 2 as
> - *  published by the Free Software Foundation.
>   */
>
>  #include <linux/gpio/consumer.h>
> --
> 2.20.1
>
Andy Shevchenko March 25, 2019, 10:35 a.m. UTC | #2
On Mon, Mar 25, 2019 at 09:30:31AM +0100, Bartosz Golaszewski wrote:
> pt., 22 mar 2019 o 21:33 Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> napisał(a):
> >
> > Reduce size of duplicated comments by switching to use SPDX identifier.
> >
> > No functional change.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/gpio/gpio-74x164.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> > index fbd8478dae3d..1562da217fb5 100644
> > --- a/drivers/gpio/gpio-74x164.c
> > +++ b/drivers/gpio/gpio-74x164.c
> > @@ -1,12 +1,9 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> It should now be: GPL-2.0-only

Do we have a document for this?

P.S. According to Documentation/process/license-rules.rst I wrote correct.
If there is a change, it should be, on my opinion,
   a) effective thru the above documentation file
   b) tons of existing headers converted (again, sic!)

I can't considered b) as a good idea, thus, even a) takes place I would expect
it allows to use both forms.
Andy Shevchenko March 25, 2019, 11:39 a.m. UTC | #3
On Mon, Mar 25, 2019 at 12:35:13PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 25, 2019 at 09:30:31AM +0100, Bartosz Golaszewski wrote:
> > pt., 22 mar 2019 o 21:33 Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> napisał(a):
> > >
> > > Reduce size of duplicated comments by switching to use SPDX identifier.
> > >
> > > No functional change.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/gpio/gpio-74x164.c | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> > > index fbd8478dae3d..1562da217fb5 100644
> > > --- a/drivers/gpio/gpio-74x164.c
> > > +++ b/drivers/gpio/gpio-74x164.c
> > > @@ -1,12 +1,9 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > 
> > It should now be: GPL-2.0-only
> 
> Do we have a document for this?

OK, it's mentioned under SPDX License List v3.0.
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index fbd8478dae3d..1562da217fb5 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -1,12 +1,9 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
  *  74Hx164 - Generic serial-in/parallel-out 8-bits shift register GPIO driver
  *
  *  Copyright (C) 2010 Gabor Juhos <juhosg@openwrt.org>
  *  Copyright (C) 2010 Miguel Gaio <miguel.gaio@efixo.com>
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
  */
 
 #include <linux/gpio/consumer.h>