From patchwork Mon Mar 18 23:37:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1058161 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="InszUE3e"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44NXfg6GCXz9s71 for ; Tue, 19 Mar 2019 10:37:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfCRXhq (ORCPT ); Mon, 18 Mar 2019 19:37:46 -0400 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:50704 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbfCRXhm (ORCPT ); Mon, 18 Mar 2019 19:37:42 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id D835DB6E for ; Mon, 18 Mar 2019 23:37:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Os3AhqExc081 for ; Mon, 18 Mar 2019 18:37:40 -0500 (CDT) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 9D6C7195 for ; Mon, 18 Mar 2019 18:37:40 -0500 (CDT) Received: by mail-it1-f198.google.com with SMTP id 9so15962876ita.8 for ; Mon, 18 Mar 2019 16:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=hvaDOjczP2tHJR7iHoTrMBVqF/jk1BbRhfkP/xYyhpk=; b=InszUE3eMG9KncrTEvwHus8HEHLwffbWywS9fcIfyzigVnqenD9xipoPx4Y+kJNIgB +COYwwaNYeF4ofL10LvsnHO3+ivCNmM81bzYL7/voS2b0lsO2QfFraP0Ti/jbsaQV5iQ A1xF42NI9awG8Bd/jOJVCyncNduslHJJaguQWm+8N5nsiKIdLJbtvyG137Howgeh8I4j enO5tFTvKW6P2xyHSz8S9/9P5KCzL+H1jN0MuKpTeuFi5kzCrneIfE5dsTAOih/zaHjo N+cnJvi82fai34TVGLK33KRhuFnIzR3jhEqu+7nk5p0aTO7yLpnygbbWr4cjy2QdFPGK N/CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hvaDOjczP2tHJR7iHoTrMBVqF/jk1BbRhfkP/xYyhpk=; b=OQDOq3lN0VEHMJlPW2YxEIiGhWyqVtD76a35swnRNuq2F2UivEEySwHpPP0QeGUhKr QqGXeUssDhSx/4hcjyaczCc3Bj3PTJZp0wlygFlSryxsn26G0pdnBCWSsmkox3NsFwmF Tt8r7dzL2IF3iyzfgea9iPnguIFWbqOhsKQmGXR8LJr7ppt9B+oPUcD3Wj1ps9YmrUXc wAYHQ2WsslYTdwskT7g0KoamLbcsoo8x1E/+TDC/GJTyv0f4Fy6Z2h5IQzENtemi5iht 7+2ZUCZiDMejv5/QchAfIF7W1yhym8fkuOcYz1LzXfhItIVl3UlsJ2340xuCmS0+pnG5 7hjg== X-Gm-Message-State: APjAAAVQrF4tyC42t4O+4hGkJisBXtihsOxs4LYzizUXSbmVjRMasnBw AanPdWBW6ynwSPgjxnIeYkYNG4vBTqNAo4Ne8bOTiuhZESSTyiTYH0KbbUoszhxwR6dK4R6iUiY IzGP9q9u3zZ7YW9fAweSoXLV3BQ== X-Received: by 2002:a02:6206:: with SMTP id d6mr13418334jac.84.1552952260270; Mon, 18 Mar 2019 16:37:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmIUfGLwQfLoHNZinT/FegiBPPbmUDCWvz2HhE/kyuqN+nHe5tkwREPmSuCIB0Y8/Ra9pZow== X-Received: by 2002:a02:6206:: with SMTP id d6mr13418320jac.84.1552952260096; Mon, 18 Mar 2019 16:37:40 -0700 (PDT) Received: from lenovo-1.hsd1.mn.comcast.net (c-73-242-25-233.hsd1.mn.comcast.net. [73.242.25.233]) by smtp.googlemail.com with ESMTPSA id 202sm673429itl.1.2019.03.18.16.37.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 16:37:39 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Linus Walleij , Jisheng Zhang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: berlin: as370: Fix to avoid NULL pointer dereference Date: Mon, 18 Mar 2019 18:37:27 -0500 Message-Id: <20190318233734.9991-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org of_match_device in as370_pinctrl_probe can return a NULL value when the matching device is not found. The patch avoids a potential dereference in such scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/berlin/pinctrl-as370.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/berlin/pinctrl-as370.c b/drivers/pinctrl/berlin/pinctrl-as370.c index 44f8ccdbeeff..78bb5b866c99 100644 --- a/drivers/pinctrl/berlin/pinctrl-as370.c +++ b/drivers/pinctrl/berlin/pinctrl-as370.c @@ -337,6 +337,8 @@ static int as370_pinctrl_probe(struct platform_device *pdev) struct resource *res; void __iomem *base; + if (!match) + return -ENODEV; rmconfig = devm_kzalloc(&pdev->dev, sizeof(*rmconfig), GFP_KERNEL); if (!rmconfig) return -ENOMEM;