From patchwork Mon Mar 18 23:31:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1058158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="Nsudj+AC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44NXWZ5hXmz9ryj for ; Tue, 19 Mar 2019 10:31:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726639AbfCRXbg (ORCPT ); Mon, 18 Mar 2019 19:31:36 -0400 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:47222 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbfCRXbg (ORCPT ); Mon, 18 Mar 2019 19:31:36 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 6225AB62 for ; Mon, 18 Mar 2019 23:31:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D1fUGLedVNNX for ; Mon, 18 Mar 2019 18:31:35 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 32160B52 for ; Mon, 18 Mar 2019 18:31:35 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id i24so14743739iol.21 for ; Mon, 18 Mar 2019 16:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=zgRFhLxzpJ7c1cVSurud7qrZsU1/Dr6blkVH1A1cauA=; b=Nsudj+AC3bbNXtGkXBvwiKIj0ap1adZAgF3Y9Worm99pAbWxUvZHFAjez+WO8QhnBU DbAFOIzagqfBpLXlJIoM1DOeZ/HmdLbbu0yIL7JxL1jxwFeHWXo3xLEL3FmoW/HNGko3 q5do/0QyFGRzOmuI1anFHeUqEvHDxiSuu1Gkb7e2ZS51YMjcEW5RD1aeHSzVfqfV39SK i477Jnd6K+0GbHpZ0eHm7VsV9IXWdMo4s6XgwUxTgDh6pjCrOapR6aQL7bQNhm/zrFuV fj4YXGM6Tn43wk/JPCcoVw3lV5vapD3OpKyTuHrFQ9DV5TV+ouWgUCiRxCk0cICSaE2T lw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zgRFhLxzpJ7c1cVSurud7qrZsU1/Dr6blkVH1A1cauA=; b=W1AZ74gS93k3Zi2jTyOkPuMKPgmqAJ4BZEvlndGAuR8FFB5TnAMHoOD5XQH6v9/bRv piJ1TLZeAhzmlIx/pzs08ZRpObRpf+SjSz0Aigx3Hij6yM8MbTSi7UQP7iYKrNb8+QIv VbbUAA/lXEWkwKuWRvAP0P9HKy8wR6dIsglzG1Ov6w2TKKbBwRk5TRghSbJeIM6RJY2Q K1UFIMNhIQnLAkK1AdT7EFU5u2VDK9gXYYeWdbriDBqM0zTOsJAq/t31cjQB3QrZlHT/ mXTNTYTLTL2tyfeRQgpI6arl39mbXeG3+Tf7dBFF0dRI9NPhLoWH5vB0jHsFQALzYYuO 6+DA== X-Gm-Message-State: APjAAAUQdS2a2WPpKVGu/MGXvDwMzTUEOQavAw34xv8bQmoXMkJ8BMJ+ BcqNWibeqDmTdgfyGdarNXOgVY+xeSdVE4Jx4587X7yvd8m/XDhWePtZMS6XqEglqZs/BpjLKlK FSV5Txri2UMOVP7slAnP3bzEiUw== X-Received: by 2002:a02:393:: with SMTP id e19mr13223760jae.95.1552951894873; Mon, 18 Mar 2019 16:31:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6xAt+OjTK7+lkfE0k2tfqiTEHUEtixtb/oi3fVAgQ8Dxpg4GJkEEo6LeCkxmwkjRWUPZTgA== X-Received: by 2002:a02:393:: with SMTP id e19mr13223749jae.95.1552951894708; Mon, 18 Mar 2019 16:31:34 -0700 (PDT) Received: from lenovo-1.hsd1.mn.comcast.net (c-73-242-25-233.hsd1.mn.comcast.net. [73.242.25.233]) by smtp.googlemail.com with ESMTPSA id o141sm476991ito.14.2019.03.18.16.31.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 16:31:34 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Linus Walleij , Jisheng Zhang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: berlin: Fix to avoid NULL pointer dereference Date: Mon, 18 Mar 2019 18:31:29 -0500 Message-Id: <20190318233131.9642-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org of_match_device can return a NULL value when the matching device is not found. The patch avoids a potential dereference in such scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/berlin/berlin-bg4ct.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/berlin/berlin-bg4ct.c b/drivers/pinctrl/berlin/berlin-bg4ct.c index 6a7fe929a68b..2d5e82938ef9 100644 --- a/drivers/pinctrl/berlin/berlin-bg4ct.c +++ b/drivers/pinctrl/berlin/berlin-bg4ct.c @@ -456,6 +456,9 @@ static int berlin4ct_pinctrl_probe(struct platform_device *pdev) struct resource *res; void __iomem *base; + if (!match) + return -ENODEV; + rmconfig = devm_kzalloc(&pdev->dev, sizeof(*rmconfig), GFP_KERNEL); if (!rmconfig) return -ENOMEM;