From patchwork Tue Mar 12 15:19:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1055466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="QXh2hFWl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44JdtS6Hfcz9s47 for ; Wed, 13 Mar 2019 02:19:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfCLPT1 (ORCPT ); Tue, 12 Mar 2019 11:19:27 -0400 Received: from mta-p5.oit.umn.edu ([134.84.196.205]:42274 "EHLO mta-p5.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbfCLPTX (ORCPT ); Tue, 12 Mar 2019 11:19:23 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id E9AF7543 for ; Tue, 12 Mar 2019 15:19:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZJySvc_1dNJe for ; Tue, 12 Mar 2019 10:19:21 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id BEB011AE for ; Tue, 12 Mar 2019 10:19:21 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id e1so1989296iod.23 for ; Tue, 12 Mar 2019 08:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=TDbruUSn2kMZp/MgTUJbLp0m/oWtXeu0QPIZQKwJ2Gk=; b=QXh2hFWloaPUDbs0VLAO28oUxqOqQetyiYLXwOfyeS0H86EMcfRTT+12hKC2H5YTeJ tCgjgNFfPMDDZnGK5xKITD4KTPl2PIpUvIlgyLVh/b16FxbEYqc29AF0mlpcn3V3BDOi 2a5d2az/K7H6TweoQ6mIlFOCgRXnTDRmKVvrkKSU9m0oUEPlLkjE8rJHgNy6k28pk+YQ IeJCXwM3R5HFF9DOt0YPZjKJZxqk2yYrMjiIuigAXOln+AlEoOxT5prtPnxo86R0aM0J Bu35WHjdyy/dUaiCBAnyiYnxfBLJh85UjNSjhoSZY0jRIBX+GUZPIOwqVWVEc/tGcu6F 9pjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TDbruUSn2kMZp/MgTUJbLp0m/oWtXeu0QPIZQKwJ2Gk=; b=Y8mPom7l47a+kyxgRrOqRXOsA44x+d3kPtah9tbwxQ8FrTohI2oGTRJHcZEwFzbATv 8lbs03HmHS0OQhp6JLNU5Fgis+Y6oLlWCfuLLfugJ5vRIXwKxXRYwc+HnowSQaiP1oDp GGhF1gcN/xCDG3cPy7AumxMbJ/XxaWMWyt3UdMz5dRhZSD20n0BWcmEpornpiftNTrom q0Nokn0REmS2BnujP2YVHt9rPxXGyGCelWr51/jmaXY2lXmboxMUZ0FqMyjGExEB7rDI URaxdhPVCFkF1jAp7+N93I3kDNFCoYDI9z4qfe8CYAL1oYW/JfNoTPYVnnb9rScFpOT8 Qrxg== X-Gm-Message-State: APjAAAXp8CZO5dAVvxJlNMmRt0Kw2+gbAJyx/AC/VceqZMWTGj4DJDm/ QUtQtqlHZPcGwICzwwnpXMp7puvtYONFNltn1xJJkyr5q66qlRy2oiEaFDi62Jhde00l9TQgGnn NqobKp2JYYPpw2EWLj/gca0z2yQ== X-Received: by 2002:a5e:dd44:: with SMTP id u4mr1422858iop.44.1552403961403; Tue, 12 Mar 2019 08:19:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXSCkBYKmyeXFFp07bTAbszkcRSihTbPavUH9pynngRsRjhnoAvEEMHPPXIexEHMG1h1XNXA== X-Received: by 2002:a5e:dd44:: with SMTP id u4mr1422838iop.44.1552403961114; Tue, 12 Mar 2019 08:19:21 -0700 (PDT) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id 136sm387605itu.35.2019.03.12.08.19.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 08:19:20 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Linus Walleij , Chen-Yu Tsai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: axp209: Fix NULL pointer dereference after allocation Date: Tue, 12 Mar 2019 10:19:10 -0500 Message-Id: <20190312151911.2207-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org axp20x_build_funcs_groups allocates groups via devm_kcalloc and tries to dereference without checking for NULL. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/pinctrl-axp209.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp209.c index afd0b533c40a..4fcf7262bed9 100644 --- a/drivers/pinctrl/pinctrl-axp209.c +++ b/drivers/pinctrl/pinctrl-axp209.c @@ -366,6 +366,8 @@ static int axp20x_build_funcs_groups(struct platform_device *pdev) pctl->funcs[i].groups = devm_kcalloc(&pdev->dev, npins, sizeof(char *), GFP_KERNEL); + if (!pctl->funcs[i].groups) + return -ENOMEM; for (pin = 0; pin < npins; pin++) pctl->funcs[i].groups[pin] = pctl->desc->pins[pin].name; }