| Message ID | 20190220111240.10041-2-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | drivers: new helper for ioremapping memory resources | expand |
On Wed, Feb 20, 2019 at 12:12:39PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > There are currently 1200+ instances of using platform_get_resource() > and devm_ioremap_resource() together in the kernel tree. > > This patch wraps these two calls in a single helper. Thanks to that > we don't have to declare a local variable for struct resource * and can > omit the redundant argument for resource type. We also have one > function call less. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
śr., 20 lut 2019 o 12:16 Greg Kroah-Hartman <gregkh@linuxfoundation.org> napisał(a): > > On Wed, Feb 20, 2019 at 12:12:39PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > There are currently 1200+ instances of using platform_get_resource() > > and devm_ioremap_resource() together in the kernel tree. > > > > This patch wraps these two calls in a single helper. Thanks to that > > we don't have to declare a local variable for struct resource * and can > > omit the redundant argument for resource type. We also have one > > function call less. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Should this go through the driver-core tree? Bart
On Wed, Feb 20, 2019 at 12:21:26PM +0100, Bartosz Golaszewski wrote: > śr., 20 lut 2019 o 12:16 Greg Kroah-Hartman > <gregkh@linuxfoundation.org> napisał(a): > > > > On Wed, Feb 20, 2019 at 12:12:39PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > There are currently 1200+ instances of using platform_get_resource() > > > and devm_ioremap_resource() together in the kernel tree. > > > > > > This patch wraps these two calls in a single helper. Thanks to that > > > we don't have to declare a local variable for struct resource * and can > > > omit the redundant argument for resource type. We also have one > > > function call less. > > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Should this go through the driver-core tree? No need, put it through the tree for patch 2/2. thanks, greg k-h
śr., 20 lut 2019 o 13:15 Greg Kroah-Hartman <gregkh@linuxfoundation.org> napisał(a): > > On Wed, Feb 20, 2019 at 12:21:26PM +0100, Bartosz Golaszewski wrote: > > śr., 20 lut 2019 o 12:16 Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> napisał(a): > > > > > > On Wed, Feb 20, 2019 at 12:12:39PM +0100, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > > > There are currently 1200+ instances of using platform_get_resource() > > > > and devm_ioremap_resource() together in the kernel tree. > > > > > > > > This patch wraps these two calls in a single helper. Thanks to that > > > > we don't have to declare a local variable for struct resource * and can > > > > omit the redundant argument for resource type. We also have one > > > > function call less. > > > > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > > Should this go through the driver-core tree? > > No need, put it through the tree for patch 2/2. > > thanks, > > greg k-h Linus, can you take the two patches for v5.1? Bart
On Thu, Feb 21, 2019 at 10:53 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > Should this go through the driver-core tree? > > > > No need, put it through the tree for patch 2/2. > > > > thanks, > > > > greg k-h > > Linus, > > can you take the two patches for v5.1? Yup both merged to the GPIO tree, thanks! Yours, Linus Walleij
diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 1c958eb33ef4..f82691e1c26c 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -79,6 +79,24 @@ struct resource *platform_get_resource(struct platform_device *dev, } EXPORT_SYMBOL_GPL(platform_get_resource); +/** + * devm_platform_ioremap_resource - call devm_ioremap_resource() for a platform + * device + * + * @pdev: platform device to use both for memory resource lookup as well as + * resource managemend + * @index: resource index + */ +void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev, + unsigned int index) +{ + struct resource *res; + + res = platform_get_resource(pdev, IORESOURCE_MEM, index); + return devm_ioremap_resource(&pdev->dev, res); +} +EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource); + /** * platform_get_irq - get an IRQ for a device * @dev: platform device diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index c7c081dc6034..b126b73ed8ef 100644 --- a/include/linux/platform_device.h +++ b/include/linux/platform_device.h @@ -52,6 +52,9 @@ extern struct device platform_bus; extern void arch_setup_pdev_archdata(struct platform_device *); extern struct resource *platform_get_resource(struct platform_device *, unsigned int, unsigned int); +extern void __iomem * +devm_platform_ioremap_resource(struct platform_device *pdev, + unsigned int index); extern int platform_get_irq(struct platform_device *, unsigned int); extern int platform_irq_count(struct platform_device *); extern struct resource *platform_get_resource_byname(struct platform_device *,