From patchwork Wed Jan 16 08:21:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1025686 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jjwzezcW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fgCP3bK4z9sCX for ; Wed, 16 Jan 2019 19:21:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728726AbfAPIVT (ORCPT ); Wed, 16 Jan 2019 03:21:19 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:44090 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728658AbfAPIVS (ORCPT ); Wed, 16 Jan 2019 03:21:18 -0500 Received: by mail-lf1-f66.google.com with SMTP id z13so4151027lfe.11 for ; Wed, 16 Jan 2019 00:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z27WWP/cKKdfJ/qLFUMIj0GJqLOsy7raZASVRvwLgfs=; b=jjwzezcWZEE8g8Q99D8U6tHCQjOMAkFpQQtBkBxEnUlirOIkQjKlFv+TkaHD83Qy+Q Ah23STm+kAjeMet8PZ7IdRuHqWr4QIv0VoSrWxvrB8mmXtxEu60GhD3y4y0wkhQaWv2a 1zFHm/5F/rJD92PSA0NsPgnBKeChgOmFNExe8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z27WWP/cKKdfJ/qLFUMIj0GJqLOsy7raZASVRvwLgfs=; b=F8MqNdABHP+nJcOKGsQLtsXCeCOzS7QR9t/jNDUXBe44sTyTRwiCUCH50wvPcUb74F BX29g7DvvE6Fc1EAGGbz+mLuyTC0qrH/KUPagiuRzkriutdjZVu92iVHXLHu+LnYL/ri aEHcB74sO0qZ6wJuiRj6tb0d+gu8Faj3IlitINfZQfnv1HJpKOXXl6J16oqhyWxm7W+J 4F4/BKza1LF23tzRCyorsZm++j5cD5tvVgxljLbCWFbBtro4P7wHnESzFqdZ5COgR0N6 fqbdYB6KFImmtU5z3HLRc1c2inJxV7WJiffze8CuhiEYeiK9VxWHPPYmr5DUBVWnlKCn WHCA== X-Gm-Message-State: AJcUukfKv+Wz35rjSKZw0HxL8sjrXIFmZvSW0Q9EpglDucexWeim+fWI lioXcTVv+oXLRiQkJE6O6XIj+/fMKAw= X-Google-Smtp-Source: ALg8bN5217BqrgrZVriZ79sphq38uZraFcfOu88crUktgYKjZARxqAGjifCLtyQSIqitW2dxmFstBg== X-Received: by 2002:a19:db82:: with SMTP id t2mr6181815lfi.130.1547626876662; Wed, 16 Jan 2019 00:21:16 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id z9sm1035095lfj.79.2019.01.16.00.21.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 00:21:15 -0800 (PST) From: Linus Walleij To: Mark Brown , linux-spi@vger.kernel.org Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , linuxarm@huawei.com, Linus Walleij , Jan Kotas Subject: [PATCH 1/4 v3] spi: Support high CS when using descriptors Date: Wed, 16 Jan 2019 09:21:07 +0100 Message-Id: <20190116082110.5604-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All controllers using GPIO descriptors can by definition support high CS connections, so just enforce this when registering an SPI controller. This fixes a regression where controllers were missing SPI_CS_HIGH, the drivers would fail like this: spi spi0.0: setup: unsupported mode bits 4 cdns-spi fd0b0000.spi: can't setup spi0.0, status -22 This is because as using descriptors moves the CS inversion logic over to gpiolib, all such controllers are registered with CS active high. Cc: Jan Kotas Reported-by: Jan Kotas Tested-by: Jan Kotas Fixes: f3186dd87669 ("spi: Optionally use GPIO descriptors for CS GPIOs") Signed-off-by: Linus Walleij --- ChangeLog v1->v3: - Collected Jan's Tested-by --- drivers/spi/spi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 06b9139664a3..31696f2fc8d5 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2336,6 +2336,11 @@ int spi_register_controller(struct spi_controller *ctlr) status = spi_get_gpio_descs(ctlr); if (status) return status; + /* + * A controller using GPIO descriptors always + * supports SPI_CS_HIGH if need be. + */ + ctlr->mode_bits |= SPI_CS_HIGH; } else { /* Legacy code path for GPIOs from DT */ status = of_spi_register_master(ctlr);