| Message ID | 20171206163002.26742-1-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: mockup: fix a return value check | expand |
On Wed, Dec 6, 2017 at 5:30 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > The return value of platform_device_register_resndata() on error is > an error code converted to pointer with ERR_PTR(), not NULL. > > Check the return value correctly. > > Fixes: 8a39f597bcfd ("gpio: mockup: rework device probing") > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index ea8c730d8af1..3a545ad17817 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -387,11 +387,11 @@ static int __init gpio_mockup_init(void) GPIO_MOCKUP_NAME, i, NULL, 0, &pdata, sizeof(pdata)); - if (!pdev) { + if (IS_ERR(pdev)) { gpio_mockup_err("error registering device"); platform_driver_unregister(&gpio_mockup_driver); gpio_mockup_unregister_pdevs(); - return -ENOMEM; + return PTR_ERR(pdev); } gpio_mockup_pdevs[i] = pdev;
The return value of platform_device_register_resndata() on error is an error code converted to pointer with ERR_PTR(), not NULL. Check the return value correctly. Fixes: 8a39f597bcfd ("gpio: mockup: rework device probing") Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> --- drivers/gpio/gpio-mockup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)