From patchwork Mon Nov 27 10:48:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 841604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="Ax21EVY6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ylk8C0DDcz9sRg for ; Mon, 27 Nov 2017 21:49:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbdK0Kta (ORCPT ); Mon, 27 Nov 2017 05:49:30 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34659 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbdK0Kt2 (ORCPT ); Mon, 27 Nov 2017 05:49:28 -0500 Received: by mail-wr0-f194.google.com with SMTP id k18so20976279wre.1 for ; Mon, 27 Nov 2017 02:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1vuhQbdTAZyt22vHYkI9k40P2FJuusmcuQ++liRT9uI=; b=Ax21EVY6I8fG99p8TucVNBSBy/KVTQ14WFA+P/ancpZIyHXMftV0m9hjF2CxupB+eV t1Vgd50/72WhY4E+A1vSZ0PzxNouaZbcaXLc9phOvflJQxePKUsmWBdeSrPWTB3NobFk W2sVxhEKHpKRAOFjjZ5EXBR7BM+xkvovtFCpPXwJKIWwA9VOw8N1KCoFlTOFCD9s0HR4 s/8PbWZfVqCzhcfL1ANKnoDlodEmHjon+OrraVQY3rniZL+ff+9punJz/FEhrF/dIADb sBilJuVgahhB5S3ULo4M93JT07opf2DPqRPsz58i3bAimOUNdPAmG0+3MXwrpK6RLYsY IYuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1vuhQbdTAZyt22vHYkI9k40P2FJuusmcuQ++liRT9uI=; b=Q8/f2C2Qbzm7ykVBT5AL6ULe/N5Vd+rEefQhCS9YBmsQvgxQNIlrEEePBR3aYCj5+z 74r2GF0E43+5uwe2NiOLXTSfW5ikQ3XnozoLhP6lvLqTJ7AmlV33OTFDRpwkmSr8bLvm 7qrZgQzEifW4oN1hu+G2p5lvedk0ux/x07Kgi83znCxHAW2XLAhwczqplHh/2l5NHGLx QxW75afcZhTmXS7LrO5ZHOY9nYA22A6jmtKFhFnVIZ9kH765mg+aNk5KXB/9AGLzfnkv 4sX8luljQ9CRtUJgRhOZnYbBNc6d69vV/4AfBEy0BuK1o/2Q0aYMs4jYQwuCto6vLGkJ fKqw== X-Gm-Message-State: AJaThX4ozxQdgfiCG+QAjcWTOkZO00LMfkFgnzYdvyZy5aFJ6avbRUsw ioiHXXyDZdSQaDjcLQbiGlJGbw== X-Google-Smtp-Source: AGs4zMZUlNq4hKp1HMvImNEQ0/52KyTNjq9HTz9qDRguxu6finiNuqtVkS4i299sZ9kDzoakL498cw== X-Received: by 10.223.134.216 with SMTP id 24mr34037685wry.156.1511779767704; Mon, 27 Nov 2017 02:49:27 -0800 (PST) Received: from bgdev-debian.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id 68sm21071741wmh.2.2017.11.27.02.49.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 02:49:27 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Bamvor Jian Zhang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 18/18] gpio: mockup: add helpers for accessing the gpio ranges Date: Mon, 27 Nov 2017 11:48:54 +0100 Message-Id: <20171127104854.333-19-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171127104854.333-1-brgl@bgdev.pl> References: <20171127104854.333-1-brgl@bgdev.pl> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In order to avoid repeating the calculations on every access - add helpers for gpio base and ngpio components of the ranges array. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index a6bfbe58bc63..ea8c730d8af1 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -81,6 +81,16 @@ module_param_named(gpio_mockup_named_lines, static struct dentry *gpio_mockup_dbg_dir; +static int gpio_mockup_range_base(unsigned int index) +{ + return gpio_mockup_ranges[index * 2]; +} + +static int gpio_mockup_range_ngpio(unsigned int index) +{ + return gpio_mockup_ranges[index * 2 + 1]; +} + static int gpio_mockup_get(struct gpio_chip *gc, unsigned int offset) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); @@ -351,7 +361,7 @@ static int __init gpio_mockup_init(void) * always be greater than 0. */ for (i = 0; i < num_chips; i++) { - if (gpio_mockup_ranges[i * 2 + 1] < 0) + if (gpio_mockup_range_ngpio(i) < 0) return -EINVAL; } @@ -367,10 +377,10 @@ static int __init gpio_mockup_init(void) for (i = 0; i < num_chips; i++) { pdata.index = index++; - pdata.base = gpio_mockup_ranges[i * 2]; + pdata.base = gpio_mockup_range_base(i); pdata.ngpio = pdata.base < 0 - ? gpio_mockup_ranges[i * 2 + 1] - : gpio_mockup_ranges[i * 2 + 1] - pdata.base; + ? gpio_mockup_range_ngpio(i) + : gpio_mockup_range_ngpio(i) - pdata.base; pdata.named_lines = gpio_mockup_named_lines; pdev = platform_device_register_resndata(NULL,