[13/18] gpio: mockup: verify that ngpio > 0

Message ID	20171127104854.333-14-brgl@bgdev.pl
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl> Subject: [PATCH 13/18] gpio: mockup: verify that ngpio > 0 Date: Mon, 27 Nov 2017 11:48:49 +0100 Message-Id: <20171127104854.333-14-brgl@bgdev.pl> In-Reply-To: <20171127104854.333-1-brgl@bgdev.pl> References: <20171127104854.333-1-brgl@bgdev.pl> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	gpio: mockup: updates for v4.16 \| expand [00/18] gpio: mockup: updates for v4.16 [01/18] gpio: mockup: add missing prefixes [02/18] gpio: mockup: parse the module params in init, not probe [03/18] gpio: mockup: verify the number of GPIO chips requested [04/18] gpio: mockup: rework device probing [05/18] gpio: mockup: implement gpio_mockup_err() [06/18] gpio: mockup: remove a stray tab [07/18] gpio: mockup: merge gpio_mockup_add() into gpio_mockup_probe() [08/18] gpio: mockup: pass the named_lines parameter over platform_data [09/18] gpio: mockup: extend the debugfs layout [10/18] gpio: mockup: change the type of value field in line state struct [11/18] gpio: mockup: group code by logic [12/18] gpio: mockup: fix debugfs handling [13/18] gpio: mockup: verify that ngpio > 0 [14/18] gpio: mockup: tweak line breaks [15/18] gpio: mockup: implement gpio_mockup_set_multiple() [16/18] gpio: mockup: modify the return value check for devm_irq_sim_init() [17/18] gpio: mockup: rename gpio_mockup_params_nr to gpio_mockup_num_ranges [18/18] gpio: mockup: add helpers for accessing the gpio ranges

Message ID

20171127104854.333-14-brgl@bgdev.pl

State

New

Headers

From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 13/18] gpio: mockup: verify that ngpio > 0
Date: Mon, 27 Nov 2017 11:48:49 +0100
Message-Id: <20171127104854.333-14-brgl@bgdev.pl>
In-Reply-To: <20171127104854.333-1-brgl@bgdev.pl>
References: <20171127104854.333-1-brgl@bgdev.pl>
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

gpio: mockup: updates for v4.16 | expand

Commit Message

Bartosz Golaszewski Nov. 27, 2017, 10:48 a.m. UTC

Improve the module params sanitization: bail out from init if the user
tries to pass a non-positive number of GPIO lines for any mockup chip.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/gpio/gpio-mockup.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 68a0c1e06a16..532f5807390b 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -335,6 +335,15 @@  static int __init gpio_mockup_init(void)
 	/* Each chip is described by two values. */
 	num_chips = gpio_mockup_params_nr / 2;
 
+	/*
+	 * The second value in the <base GPIO - number of GPIOS> pair must
+	 * always be greater than 0.
+	 */
+	for (i = 0; i < num_chips; i++) {
+		if (gpio_mockup_ranges[i * 2 + 1] < 0)
+			return -EINVAL;
+	}
+
 	gpio_mockup_dbg_dir = debugfs_create_dir("gpio-mockup-event", NULL);
 	if (IS_ERR_OR_NULL(gpio_mockup_dbg_dir))
 		gpio_mockup_err("error creating debugfs directory\n");

[13/18] gpio: mockup: verify that ngpio > 0

Commit Message

Patch