From patchwork Tue Oct 24 19:54:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Berger X-Patchwork-Id: 830023 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CCsCGmW0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yM3vQ6lQYz9sNx for ; Wed, 25 Oct 2017 06:57:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbdJXT4x (ORCPT ); Tue, 24 Oct 2017 15:56:53 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:54101 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbdJXTzq (ORCPT ); Tue, 24 Oct 2017 15:55:46 -0400 Received: by mail-qk0-f196.google.com with SMTP id y23so27812088qkb.10; Tue, 24 Oct 2017 12:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Aa23z+g23TzieVSxeXvowOaeqcd9quI0jIT+RptFDrE=; b=CCsCGmW0suOkQQDSL0fyQeR5pCyMh9GBI34q0VVEfejUQ7bwYYuNnDV/V6MsaYu/Mn hS1NaDchk2KxZOeWV66flYqWnkg774/gDYEpjfD74MTKkF8Z4GnHHsg4s92zYxjoJQm1 E2btRznDmy/wsLMuvitQkJocQ6Uu4REtZU2hzOc+2SluM1qBC+erpq8ot5gkzO4owFDB EZLRV2NG7tBAFExbs3QDhNLb6TrHBSafYqDlIPrTF8kjyHL1Wz7M53DuxvGML5zd2E7j XNkm4POjjFoy0ybzimL3qOXzi4BujLIj0Ksk5izpaMD+l7wQGMIRyAt+mAB5eH+3U+r2 5/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Aa23z+g23TzieVSxeXvowOaeqcd9quI0jIT+RptFDrE=; b=arfhFJ6Ds6XNn2DImsGF4F5G1IVS5wfT9JQw0Q18ZsP3DslsGyrnMfdgwPvW9F2K3/ 2tWPN/XCIcOV8DHZMMtKVCBSuk/kZ3SjYjrzplrFhGL//V15qLXVk3Au5QFXweasJFLG gRokxKJwfSXAEquGp8HUlGi6vbM3s7EnzIjJ1SJFoosJR5sOG9iCXC4zQQSnSqh18VMo UROJV1A/KVjk8XYLSBLytlIssVaaKWiNn481Jt9X1sDWv+Z5/AKScuAAtoHWApMU3QLB ecVfxTJqgr6IEGVJvEhBTXWXPkek14og7AuxBMV42D73UOPCqnHvM4pMAf76Qn9UfUsy cpOw== X-Gm-Message-State: AMCzsaXJ+2gx/o4z8x3aLdKTbylqm6piL0gTlwkk516vyG6g8RvLju7I 4bcg20meo6mPqcE2jCuXrAw= X-Google-Smtp-Source: ABhQp+TTarLZLHIDTLx+sIouxlUeeQcawQx09j8a9ka7SybVcCXuyQOXmoyNntfSewNNu3vugbKiyg== X-Received: by 10.55.107.198 with SMTP id g189mr11320974qkc.9.1508874945588; Tue, 24 Oct 2017 12:55:45 -0700 (PDT) Received: from stb-bld-02.irv.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id s27sm794249qtj.3.2017.10.24.12.55.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 12:55:45 -0700 (PDT) From: Doug Berger To: Gregory Fong Cc: Doug Berger , Linus Walleij , Brian Norris , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/7] gpio: brcmstb: correct the configuration of level interrupts Date: Tue, 24 Oct 2017 12:54:49 -0700 Message-Id: <20171024195451.30535-6-opendmb@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171024195451.30535-1-opendmb@gmail.com> References: <20171024195451.30535-1-opendmb@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This commit corrects a bug when configuring the GPIO hardware for IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_LEVEL_HIGH interrupt types. The hardware is now correctly configured to support those types. Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support") Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli Acked-by: Gregory Fong --- drivers/gpio/gpio-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index 513de4936a25..183863902f7f 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -137,13 +137,13 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type) switch (type) { case IRQ_TYPE_LEVEL_LOW: - level = 0; + level = mask; edge_config = 0; edge_insensitive = 0; break; case IRQ_TYPE_LEVEL_HIGH: level = mask; - edge_config = 0; + edge_config = mask; edge_insensitive = 0; break; case IRQ_TYPE_EDGE_FALLING: