| Message ID | 20170905075826.893066-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] pinctrl: sprd: add missing Kconfig dependency | expand |
On Tue, Sep 5, 2017 at 9:58 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The chip-specific driver fails to build when the common > part is not enabled first: > > drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove' > drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown' > > This adds a Kconfig dependency to ensure this is always > the case. > > Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> I got a fix for this and the other problem from Randy Dunlap already. Thanks anyway! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig index 6f4a7f9ac6fd..ec21b8bae487 100644 --- a/drivers/pinctrl/sprd/Kconfig +++ b/drivers/pinctrl/sprd/Kconfig @@ -13,5 +13,6 @@ config PINCTRL_SPRD config PINCTRL_SPRD_SC9860 bool "Spreadtrum SC9860 pinctrl driver" + depends on PINCTRL_SPRD help Say Y here to enable Spreadtrum SC9860 pinctrl driver
The chip-specific driver fails to build when the common part is not enabled first: drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove' drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown' This adds a Kconfig dependency to ensure this is always the case. Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/pinctrl/sprd/Kconfig | 1 + 1 file changed, 1 insertion(+)