| Message ID | 20170720165912.14360-1-thierry.reding@gmail.com |
|---|---|
| State | New |
| Headers | show |
Thierry Reding <thierry.reding@gmail.com> writes: > From: Thierry Reding <treding@nvidia.com> > > The irq_group field stores a 1:1 mapping. Use the loop variable to > derive the values instead of storing them in an extra array. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Reviewed-by: Eric Anholt <eric@anholt.net>
On Thu, Jul 20, 2017 at 06:59:12PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The irq_group field stores a 1:1 mapping. Use the loop variable to > derive the values instead of storing them in an extra array. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Ping... Thierry
On Thu, Jul 20, 2017 at 6:59 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > From: Thierry Reding <treding@nvidia.com> > > The irq_group field stores a 1:1 mapping. Use the loop variable to > derive the values instead of storing them in an extra array. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Patch applied with Eric's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index a605d74552b6..834d4862dd15 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -92,7 +92,6 @@ struct bcm2835_pinctrl { struct gpio_chip gpio_chip; struct pinctrl_gpio_range gpio_range; - int irq_group[BCM2835_NUM_IRQS]; spinlock_t irq_lock[BCM2835_NUM_BANKS]; }; @@ -400,7 +399,7 @@ static void bcm2835_gpio_irq_handler(struct irq_desc *desc) for (i = 0; i < ARRAY_SIZE(pc->irq); i++) { if (pc->irq[i] == irq) { - group = pc->irq_group[i]; + group = i; break; } } @@ -1047,7 +1046,6 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) for (i = 0; i < BCM2835_NUM_IRQS; i++) { pc->irq[i] = irq_of_parse_and_map(np, i); - pc->irq_group[i] = i; if (pc->irq[i] == 0) continue;