| Message ID | 20170614091209.GC29394@elgon.mountain |
|---|---|
| State | New |
| Headers | show |
On Wed, Jun 14, 2017 at 11:12 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > devm_pinctrl_register() returns error pointers, it doesn't return NULL. > > Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index d8473d929cb1..d8e8842967d6 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev) } jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc); - if (!jzpc->pctl) { + if (IS_ERR(jzpc->pctl)) { dev_err(dev, "Failed to register pinctrl\n"); - return -EINVAL; + return PTR_ERR(jzpc->pctl); } for (i = 0; i < chip_info->num_groups; i++) {
devm_pinctrl_register() returns error pointers, it doesn't return NULL. Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html