Message ID | 20170517102514.89744-4-mika.westerberg@linux.intel.com |
---|---|
State | New |
Headers | show |
On Wed, May 17, 2017 at 1:25 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > It turns out there are quite many Chromebooks out there that have the > same keyboard issue than Acer Chromebook. All of them are based on > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions > for which we add separate entries). > > Instead of adding each machine to the quirk table, we use > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the > machines out there currently. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945 > Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c > index e35d0fe4c737..20f1b4493994 100644 > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > @@ -1539,13 +1539,26 @@ static void chv_gpio_irq_handler(struct irq_desc *desc) > * is not listed below. > */ > static const struct dmi_system_id chv_no_valid_mask[] = { > + /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */ > { > - /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */ > - .ident = "Acer Chromebook (CYAN)", > + .ident = "Intel_Strago based Chromebooks (All models)", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > - DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), > - DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"), > + }, > + }, > + { > + .ident = "Acer Chromebook R11 (Cyan)", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"), > + }, > + }, > + { > + .ident = "Samsung Chromebook 3 (Celes)", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Celes"), > }, > }, > {} > -- > 2.11.0 >
On Wed, May 17, 2017 at 12:25 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > It turns out there are quite many Chromebooks out there that have the > same keyboard issue than Acer Chromebook. All of them are based on > Intel_Strago reference and report their DMI_PRODUCT_FAMILY as > "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions > for which we add separate entries). > > Instead of adding each machine to the quirk table, we use > DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the > machines out there currently. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945 > Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Patch applied with Andy's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index e35d0fe4c737..20f1b4493994 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1539,13 +1539,26 @@ static void chv_gpio_irq_handler(struct irq_desc *desc) * is not listed below. */ static const struct dmi_system_id chv_no_valid_mask[] = { + /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */ { - /* See https://bugzilla.kernel.org/show_bug.cgi?id=194945 */ - .ident = "Acer Chromebook (CYAN)", + .ident = "Intel_Strago based Chromebooks (All models)", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), - DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), - DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), + DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"), + }, + }, + { + .ident = "Acer Chromebook R11 (Cyan)", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), + DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"), + }, + }, + { + .ident = "Samsung Chromebook 3 (Celes)", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), + DMI_MATCH(DMI_PRODUCT_NAME, "Celes"), }, }, {}
It turns out there are quite many Chromebooks out there that have the same keyboard issue than Acer Chromebook. All of them are based on Intel_Strago reference and report their DMI_PRODUCT_FAMILY as "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are exceptions for which we add separate entries). Instead of adding each machine to the quirk table, we use DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the machines out there currently. Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945 Suggested: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-cherryview.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)