| Message ID | 20170517102514.89744-3-mika.westerberg@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
On Wed, May 17, 2017 at 1:25 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Make sure dmi_system_id tables are NULL terminated. > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c > index 2debba62fac9..e35d0fe4c737 100644 > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), > DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), > }, > - } > + }, > + {} > }; > > static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq) > -- > 2.11.0 >
On Wed, May 17, 2017 at 12:25 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Make sure dmi_system_id tables are NULL terminated. > > Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> I already had this patch queued. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 17 May 2017 13:25:13 +0300, Mika Westerberg wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Make sure dmi_system_id tables are NULL terminated. > > Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c > index 2debba62fac9..e35d0fe4c737 100644 > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), > DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), > }, > - } > + }, > + {} > }; > > static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq) Reviewed-by: Jean Delvare <jdelvare@suse.de> This should go to stable trees IMHO.
On Thu, Jun 1, 2017 at 11:30 AM, Jean Delvare <jdelvare@suse.de> wrote: > On Wed, 17 May 2017 13:25:13 +0300, Mika Westerberg wrote: >> From: Wei Yongjun <weiyongjun1@huawei.com> >> >> Make sure dmi_system_id tables are NULL terminated. >> >> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> (...) > > This should go to stable trees IMHO. It is already upstream, but you can suggest directly to Greg to pick it to the stable trees. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 2debba62fac9..e35d0fe4c737 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), }, - } + }, + {} }; static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)