From patchwork Wed Jan 11 14:36:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 713768 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tzBLd3XcRz9sdn for ; Thu, 12 Jan 2017 01:37:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967323AbdAKOh2 (ORCPT ); Wed, 11 Jan 2017 09:37:28 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:51181 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbdAKOh1 (ORCPT ); Wed, 11 Jan 2017 09:37:27 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MGsGP-1cERrP1lth-00DWHw; Wed, 11 Jan 2017 15:37:14 +0100 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , "Agrawal, Nitesh-kumar" , Pankaj Sen , "Shah, Nehal-bakulchandra" , Shyam-sundar S-k , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning Date: Wed, 11 Jan 2017 15:36:56 +0100 Message-Id: <20170111143712.510147-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:GB0plgKyqEIRMVjyVNTICaU0ci4Bv2heb9FsJ9+TqMwYZxtMNqo sf0FdLs/MXhNRmyOlHo5MIqZTXkXOoln9cOsXHsiem/0e0mnQrza6M6U6WUYb9yW9x9+IOH FWs4Z81lqa0pFCEWaw/LlqZEwDf9c78gzuiDjEWkr7XDo3Donmt2ic9EQmtw5xlHafGhpXc d94F6NGALDN0NOibNJBqQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:VLAb6StCNJg=:Ergn/WJ20xhPWgjYupWDRH 8vJWkK1ur5Mzdox470AzP1gx7b5EqihMcR0Gp4BOZhAO3S04JSJysjfH1tDyauU8MUlKP4IcV 0uPFytre5jwPHtgqfIFlcW7lUCOUxcA6CItS3S36UcsBN0mNS3vgYPedpb4M0w6z4VyKj5bJG HqZtCF+AtaTZU29q6eRt7FHwyuX7J5fnCVz5hQPg7/OkTduIylmTaE5ySyprsRNAlrQpIG/rQ tiNrn5KdzJ1+MCuM3p4tkPcm5C/Le7TjlNFG0+isia7tNMVHCF5FPBJoaahHW+d9xs9ae7/9g K/GZeKgAkfV9lCAcp6CAaNGPMtaV4pSpEpxoH+zhPJsvy+XyeiEkAh/FUnvt1OeDe6vcpurRD SVTct0hJ2cCbnO6X0wYmjWV8NZocQtJXDtY2wVI04EuRlQGeASOWi61A3y/p/Trbck9/CXfzh CpX1FhxnB5w/fz+kI8F4vN9Na/Gr40U+0LhgQkckE9tAbj2rN2ME0YhmLYtjqRRkMkVDVdot4 bShWuAHGZFXmzk9SF+31KMziAZNM+r3LJ5PhwbJgTNv/qdCjO5vNOgcaUp00x1ioDLxk414+s 1SDmgL7Gd2XUSt8tbrVJeAZrHtEFCZtxnE7ri7fgT6QmGhxRZn91+F3lRasghA+Ai5Xs1ZuWM +e7NgFWyeI4gqPrJUXm2l4uzcIsz4v4ctB3WLEactgUU3pkxE1vtlVMQ6bCKL7Ckny9E= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Since gpio_dev->hwbank_num is now a variable, the compiler cannot figure out if pin_num is initialized at all: drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] for (; i < pin_num; i++) { ^~~ drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds a 'default' statement to make that case well-defined. Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") Signed-off-by: Arnd Bergmann --- drivers/pinctrl/pinctrl-amd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 7b95c1886f7b..9495e6eb76d1 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -206,6 +206,8 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) i = 192; pin_num = AMD_GPIO_PINS_BANK3 + i; break; + default: + return; } for (; i < pin_num; i++) { seq_printf(s, "pin%d\t", i);